[PATCH] ext4: Remove deprecated flag for noacl and noxattr_user mount options

[PATCH] ext4: Remove deprecated flag for noacl and noxattr_user mount options

[Yang Xu]

Since kernel commit f70486055ee3 ("ext4: try to deprecate noacl and
noxattr_user mount options"), we deprecated these two mount options
because no other filesystem used the

But now, acl has been used by ext4 ext2 btrfs f2fs ocfs2 and noxattr_user
has been used by ext4 ext2 f2fs ocfs2.

I think it is time to remove deprecated flag for them.

Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
 fs/ext4/super.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 450c918d68fc..8a0cc8815ee7 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -2116,10 +2116,6 @@ static int ext4_parse_param(struct fs_context *fc, struct fs_parameter *param)
 		else
 			return note_qf_name(fc, GRPQUOTA, param);
 #endif
-	case Opt_noacl:
-	case Opt_nouser_xattr:
-		ext4_msg(NULL, KERN_WARNING, deprecated_msg, param->key, "3.5");
-		break;
 	case Opt_sb:
 		if (fc->purpose == FS_CONTEXT_FOR_RECONFIGURE) {
 			ext4_msg(NULL, KERN_WARNING,
-- 
2.23.0

Re: [PATCH] ext4: Remove deprecated flag for noacl and noxattr_user mount options

[Lukas Czerner]

On Thu, Jun 02, 2022 at 06:01:39PM +0800, Yang Xu wrote:
> Since kernel commit f70486055ee3 ("ext4: try to deprecate noacl and
> noxattr_user mount options"), we deprecated these two mount options
> because no other filesystem used the
> 
> But now, acl has been used by ext4 ext2 btrfs f2fs ocfs2 and noxattr_user
> has been used by ext4 ext2 f2fs ocfs2.

And many other fs don't have it. Is that your only reason for dropping
the deprecation? I can easily imagine that those fs got it because ext4
had it at the time.

Moreover the deprecation message has been there for 10 years, have we
seen anyone actually complaining that they want to keep it?

Why not to just remove the option. I don't have a strong opinion either
way, but it would be nice to remove stuff we don't need. Do you have a
use case for it? If not, can we make it Opt_removed?

-Lukas

> 
> I think it is time to remove deprecated flag for them.
> 
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
>  fs/ext4/super.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 450c918d68fc..8a0cc8815ee7 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -2116,10 +2116,6 @@ static int ext4_parse_param(struct fs_context *fc, struct fs_parameter *param)
>  		else
>  			return note_qf_name(fc, GRPQUOTA, param);
>  #endif
> -	case Opt_noacl:
> -	case Opt_nouser_xattr:
> -		ext4_msg(NULL, KERN_WARNING, deprecated_msg, param->key, "3.5");
> -		break;
>  	case Opt_sb:
>  		if (fc->purpose == FS_CONTEXT_FOR_RECONFIGURE) {
>  			ext4_msg(NULL, KERN_WARNING,
> -- 
> 2.23.0
> 

Re: [PATCH] ext4: Remove deprecated flag for noacl and noxattr_user mount options

[xuyang2018.jy]

on 2022/06/02 19:04, Lukas Czerner wrote:
> On Thu, Jun 02, 2022 at 06:01:39PM +0800, Yang Xu wrote:
>> Since kernel commit f70486055ee3 ("ext4: try to deprecate noacl and
>> noxattr_user mount options"), we deprecated these two mount options
>> because no other filesystem used the
>>
>> But now, acl has been used by ext4 ext2 btrfs f2fs ocfs2 and noxattr_user
>> has been used by ext4 ext2 f2fs ocfs2.
>

Firstly, sorry for this late reply. I am busy with other important thing 
last month.

> And many other fs don't have it. Is that your only reason for dropping
> the deprecation?

YES.

> I can easily imagine that those fs got it because ext4
> had it at the time.

Maybe.

>
> Moreover the deprecation message has been there for 10 years, have we
> seen anyone actually complaining that they want to keep it?

I don't see any complains since 2018 because I start to test xfs/ext4 
since that time

>
> Why not to just remove the option. I don't have a strong opinion either
> way, but it would be nice to remove stuff we don't need. Do you have a
> use case for it? If not, can we make it Opt_removed?

I don't have use case for it. OK, will send a remove patch tomorrow.

Best Regards
Yang Xu
>
> -Lukas
>
>>
>> I think it is time to remove deprecated flag for them.
>>
>> Signed-off-by: Yang Xu<xuyang2018.jy@fujitsu.com>
>> ---
>>   fs/ext4/super.c | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
>> index 450c918d68fc..8a0cc8815ee7 100644
>> --- a/fs/ext4/super.c
>> +++ b/fs/ext4/super.c
>> @@ -2116,10 +2116,6 @@ static int ext4_parse_param(struct fs_context *fc, struct fs_parameter *param)
>>   		else
>>   			return note_qf_name(fc, GRPQUOTA, param);
>>   #endif
>> -	case Opt_noacl:
>> -	case Opt_nouser_xattr:
>> -		ext4_msg(NULL, KERN_WARNING, deprecated_msg, param->key, "3.5");
>> -		break;
>>   	case Opt_sb:
>>   		if (fc->purpose == FS_CONTEXT_FOR_RECONFIGURE) {
>>   			ext4_msg(NULL, KERN_WARNING,
>> --
>> 2.23.0
>>
>