linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "zhangyi (F)" <yi.zhang@huawei.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: <fstests@vger.kernel.org>, <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4/021: make sure the fdatasync subprocess exits
Date: Mon, 24 Feb 2020 19:31:06 +0800	[thread overview]
Message-ID: <2c2b8a1b-64a3-8fd7-948f-ea7a777e2cf0@huawei.com> (raw)
In-Reply-To: <20200223123411.GA3840@desktop>

Hi,

On 2020/2/23 20:34, Eryu Guan wrote:
> On Fri, Feb 14, 2020 at 10:20:01AM +0800, zhangyi (F) wrote:
>> Now we just kill fdatasync_work process and wait nothing after the
>> test, so a busy unmount failure may appear if the fdatasync syscall
>> doesn't return in time.
>>
>>   umount: /tmp/scratch: target is busy.
>>   mount: /tmp/scratch: /dev/sdb already mounted on /tmp/scratch.
>>   !!! failed to remount /dev/sdb on /tmp/scratch
>>
>> This patch kill and wait the xfs_io fdatasync subprocess to make sure
>> _check_scratch_fs success.
> 
> Yeah, that's a problem.
> 
> I think you could add another "trap" in fdatasync_work, as what
> btrfs/036 does:
> 
> 	trap "wait; exit" SIGTERM
> 
> So xfs_io will be waited by fdatasync_work before exiting.
> 

Thanks for your suggestion, I will do that.

Thanks,
Yi.


      reply	other threads:[~2020-02-24 11:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  2:20 [PATCH] ext4/021: make sure the fdatasync subprocess exits zhangyi (F)
2020-02-23 12:34 ` Eryu Guan
2020-02-24 11:31   ` zhangyi (F) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c2b8a1b-64a3-8fd7-948f-ea7a777e2cf0@huawei.com \
    --to=yi.zhang@huawei.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).