From: Eric Sandeen <sandeen@sandeen.net>
To: "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Cc: Ritesh Harjani <riteshh@linux.ibm.com>
Subject: [PATCH] ext4: do not commit super on read-only bdev
Date: Wed, 18 Mar 2020 14:19:38 -0500 [thread overview]
Message-ID: <4b6e774d-cc00-3469-7abb-108eb151071a@sandeen.net> (raw)
From: Eric Sandeen <sandeen@redhat.com>
Under some circumstances we may encounter a filesystem error on a
read-only block device, and if we try to save the error info to the
superblock and commit it, we'll wind up with a noisy error and
backtrace, i.e.:
[ 3337.146838] EXT4-fs error (device pmem1p2): ext4_get_journal_inode:4634: comm mount: inode #0: comm mount: iget: illegal inode #
------------[ cut here ]------------
generic_make_request: Trying to write to read-only block-device pmem1p2 (partno 2)
WARNING: CPU: 107 PID: 115347 at block/blk-core.c:788 generic_make_request_checks+0x6b4/0x7d0
...
To avoid this, commit the error info in the superblock only if the
block device is writable.
Reported-by: Ritesh Harjani <riteshh@linux.ibm.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
(compile-tested only FWIW)
(also, not sure if the bdev test in __save_error_info should be removed?)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 0c7c4adb664e..55392903bda5 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -372,7 +372,8 @@ static void save_error_info(struct super_block *sb, const char *func,
unsigned int line)
{
__save_error_info(sb, func, line);
- ext4_commit_super(sb, 1);
+ if (!bdev_read_only(sb->s_bdev))
+ ext4_commit_super(sb, 1);
}
/*
next reply other threads:[~2020-03-18 19:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 19:19 Eric Sandeen [this message]
2020-03-18 22:09 ` [PATCH] ext4: do not commit super on read-only bdev Andreas Dilger
2020-03-26 14:57 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b6e774d-cc00-3469-7abb-108eb151071a@sandeen.net \
--to=sandeen@sandeen.net \
--cc=linux-ext4@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).