From: Andreas Dilger <adilger@dilger.ca>
To: Jason Yan <yanaijie@huawei.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: remove useless ext4_pin_inode()
Date: Mon, 4 Mar 2019 17:41:22 -0700 [thread overview]
Message-ID: <50BB10C6-BE07-4BF7-9399-BD7A32EB3A54@dilger.ca> (raw)
In-Reply-To: <8ea5a72f-d339-450c-2604-49f730afa43b@huawei.com>
This was originally added during early ext4 development to pin open directories, but it was never really used. I don't mind to remove it.
Cheers, Andreas
> On Mar 3, 2019, at 18:31, Jason Yan <yanaijie@huawei.com> wrote:
>
> Friendly ping...
>
> Anyone can help to review this patch?
>
>> On 2019/2/27 10:20, Jason Yan wrote:
>> This function is never used from the beginning. Let's remove it.
>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>> ---
>> fs/ext4/inode.c | 30 ------------------------------
>> 1 file changed, 30 deletions(-)
>> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
>> index 34d7e0703cc6..0060d08edd92 100644
>> --- a/fs/ext4/inode.c
>> +++ b/fs/ext4/inode.c
>> @@ -6089,36 +6089,6 @@ void ext4_dirty_inode(struct inode *inode, int flags)
>> return;
>> }
>> -#if 0
>> -/*
>> - * Bind an inode's backing buffer_head into this transaction, to prevent
>> - * it from being flushed to disk early. Unlike
>> - * ext4_reserve_inode_write, this leaves behind no bh reference and
>> - * returns no iloc structure, so the caller needs to repeat the iloc
>> - * lookup to mark the inode dirty later.
>> - */
>> -static int ext4_pin_inode(handle_t *handle, struct inode *inode)
>> -{
>> - struct ext4_iloc iloc;
>> -
>> - int err = 0;
>> - if (handle) {
>> - err = ext4_get_inode_loc(inode, &iloc);
>> - if (!err) {
>> - BUFFER_TRACE(iloc.bh, "get_write_access");
>> - err = jbd2_journal_get_write_access(handle, iloc.bh);
>> - if (!err)
>> - err = ext4_handle_dirty_metadata(handle,
>> - NULL,
>> - iloc.bh);
>> - brelse(iloc.bh);
>> - }
>> - }
>> - ext4_std_error(inode->i_sb, err);
>> - return err;
>> -}
>> -#endif
>> -
>> int ext4_change_inode_journal_flag(struct inode *inode, int val)
>> {
>> journal_t *journal;
>
next prev parent reply other threads:[~2019-03-05 0:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 2:20 [PATCH] ext4: remove useless ext4_pin_inode() Jason Yan
2019-03-04 1:31 ` Jason Yan
2019-03-04 22:34 ` Theodore Y. Ts'o
2019-03-05 0:41 ` Andreas Dilger [this message]
2019-03-15 3:52 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BB10C6-BE07-4BF7-9399-BD7A32EB3A54@dilger.ca \
--to=adilger@dilger.ca \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).