From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-ext4-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 04BC9C7EE2F
	for <linux-ext4@archiver.kernel.org>; Wed, 31 May 2023 09:10:06 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235272AbjEaJKE (ORCPT <rfc822;linux-ext4@archiver.kernel.org>);
        Wed, 31 May 2023 05:10:04 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51678 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S235336AbjEaJJp (ORCPT
        <rfc822;linux-ext4@vger.kernel.org>); Wed, 31 May 2023 05:09:45 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3480AE54;
        Wed, 31 May 2023 02:09:16 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 5389F638A1;
        Wed, 31 May 2023 09:08:54 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 414AEC433EF;
        Wed, 31 May 2023 09:08:51 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1685524133;
        bh=axEkNRQxOw2SsrEsKVeeUf3LFs4+Ez60j1wdXzIL3N8=;
        h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
        b=E4gFHy8TJgSROxww8OVcO6e3p3dd7vo4i5KSweH0NOnDdcWZRx6VhzGl/tF5voshC
         UdmJJJ49kI5kmDv8uxIQcXuTasv67aBuZrAX/nFEXNjew8xfFV3/Tv9o4t/50sX560
         4osRYtHft7VGmBwOugY2d3gckgf798HrCVdO8An/XzC3FA/TtXWsZVzkSXWlRu/3m1
         UcmBmqSm6PgzPnQ6YZuJR6SC10cam6xiaiwNt5PMth2Lvq3oHSe/HVHMr8zaZl9OXp
         N3UA7Kz7at7Iul2UL15fIZVbY2+75CmNbSF/oiTJWoy68QDXpRnZJj8Do8LRZ7JegV
         xaP9uJgHiusmg==
Message-ID: <54b4a89c-4023-526e-62e3-8f7fadc2861d@kernel.org>
Date:   Wed, 31 May 2023 18:08:50 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 09/12] fs: factor out a direct_write_fallback helper
Content-Language: en-US
To:     Christoph Hellwig <hch@lst.de>,
        Matthew Wilcox <willy@infradead.org>
Cc:     Jens Axboe <axboe@kernel.dk>, Xiubo Li <xiubli@redhat.com>,
        Ilya Dryomov <idryomov@gmail.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        Theodore Ts'o <tytso@mit.edu>,
        Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
        Miklos Szeredi <miklos@szeredi.hu>,
        Andreas Gruenbacher <agruenba@redhat.com>,
        "Darrick J. Wong" <djwong@kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-block@vger.kernel.org, ceph-devel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
        linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org,
        linux-mm@kvack.org
References: <20230531075026.480237-1-hch@lst.de>
 <20230531075026.480237-10-hch@lst.de>
From:   Damien Le Moal <dlemoal@kernel.org>
Organization: Western Digital Research
In-Reply-To: <20230531075026.480237-10-hch@lst.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On 5/31/23 16:50, Christoph Hellwig wrote:
> Add a helper dealing with handling the syncing of a buffered write fallback
> for direct I/O.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks OK to me.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research