From: Andreas Dilger <adilger@dilger.ca>
To: Ritesh Harjani <riteshh@linux.ibm.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: About BUFFER_TRACE macro in include/linux/jbd2.h
Date: Tue, 7 Jan 2020 15:12:03 -0700 [thread overview]
Message-ID: <5FFDC259-0697-4505-B7DB-3E633CD03666@dilger.ca> (raw)
In-Reply-To: <20200106083020.2EF41AE064@d06av26.portsmouth.uk.ibm.com>
Hi Ritesh,
There were somewhat patch versions posted by Andrew Morton (akpm)
that may have more functionality.
Note that the block layer no longer needs to be patched for this to be
used. Instead you can use dm-flakey to cause it to discard writes to the
block device.
Cheers, Andreas
> On Jan 6, 2020, at 01:30, Ritesh Harjani <riteshh@linux.ibm.com> wrote:
>
> Hello Community,
>
> A very happy new year to all of you!! :)
>
> Had some query on BUFFER_TRACE macro. Here it goes:-
>
> While debugging some issue w.r.t jbd2/bh I came across this empty macro
> definition of BUFFER_TRACE in include/linux/jbd2.h.
> Though this is called from multiple places, but I could not find any
> definition of this as such.
>
> I could see some patches on mailing list which are still calling this
> macro. So that means I am definitely missing something here.
>
> Could you please help me understand how can one use this "BUFFER_TRACE"
> macro for debugging? I could not find any ftrace event related
> to this macro.
>
> For my debugging as of now I ended up creating a file in
> include/trace/events/buffer_debug.h and added the definition
> of BUFFER_TRACE macro there.
>
> On more googling I did find some old patch which enabled CONFIG_BUFFER_DEBUG.
> http://people.redhat.com/sct/patches/ext3-2.4/for-2.4.19/98-debug/00-ext3-debug.patch
> But this seemed pretty old and I could not find anything latest on this
> which is related to above patch.
>
> Any pointers pls?
>
> -ritesh
>
prev parent reply other threads:[~2020-01-07 22:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 8:30 About BUFFER_TRACE macro in include/linux/jbd2.h Ritesh Harjani
2020-01-07 22:12 ` Andreas Dilger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5FFDC259-0697-4505-B7DB-3E633CD03666@dilger.ca \
--to=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).