From: Kemeng Shi <shikemeng@huaweicloud.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca, ojaswin@linux.ibm.com,
ritesh.list@gmail.com
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 00/20] Some bugfix and cleanup to mballoc
Date: Fri, 10 Mar 2023 16:17:21 +0800 [thread overview]
Message-ID: <5e5691cd-3308-be3b-91d5-9fa1ab9ec98d@huaweicloud.com> (raw)
In-Reply-To: <20230303172120.3800725-1-shikemeng@huaweicloud.com>
on 3/4/2023 1:21 AM, Kemeng Shi wrote:
> Hi, this series contain some random cleanup patches and some bugfix
> patches to make EXT4_MB_HINT_GOAL_ONLY work properly, protect pa->pa_free
> from race and so on. More details can be found in git log.
> Thanks!
>
> ---
> V3:
> -patch 01/20 "ext4: set goal start correctly in
> ext4_mb_normalize_request" correctly record goal in ac_g_ex instead of
> ac_f_ex, this also trigger another original bug that wanted goal maybe
> out of valid data block range. Add valid range check in patch 01/20
> to fully fix the bug.
> -run "kvm-xfstests smoke" and all tests are passed except generic/454.
> This test also failed in running kernel without this patchset, so
> it's unlikely caused by this patchset. I'm trying to figure out the
> reason but it may take a while as I'm not family with kvm-xfstests.
> Just send this series for early review and maybe some help to pass
> the failed test case.
I re-run "kvm-xfstests smoke" with newly root_fs.img and all tests pass.
It may be the early test which triggerred bug and corruptted the metadata
casues failure.
> ---
> V2:
> -Add signed-off from Ritesh and Ojaswin to patch 3/20 "ext4: get correct
> ext4_group_info in ext4_mb_prefetch_fini" as this is a duplicate of
> a patch under reviewing.
> -Split out original patch "ext4: avoid to use preallocated blocks if
> EXT4_MB_HINT_GOAL_ONLY is set" which will be resend after improved.
> -Improve log information of patch 20.
> -Collect Reviewed-by from Ojaswin and Ritesh. Now only patch 3, 12 and
> 20 need futher review.
> ---
>
>
> Kemeng Shi (20):
> ext4: set goal start correctly in ext4_mb_normalize_request
> ext4: allow to find by goal if EXT4_MB_HINT_GOAL_ONLY is set
> ext4: get correct ext4_group_info in ext4_mb_prefetch_fini
> ext4: correct calculation of s_mb_preallocated
> ext4: correct start of used group pa for debug in ext4_mb_use_group_pa
> ext4: protect pa->pa_free in ext4_discard_allocated_blocks
> ext4: add missed brelse in ext4_free_blocks_simple
> ext4: remove unused return value of ext4_mb_try_best_found and
> ext4_mb_free_metadata
> ext4: Remove unnecessary release when memory allocation failed in
> ext4_mb_init_cache
> ext4: remove unnecessary e4b->bd_buddy_page check in
> ext4_mb_load_buddy_gfp
> ext4: remove unnecessary check in ext4_mb_new_blocks
> ext4: remove dead check in mb_buddy_mark_free
> ext4: remove ac->ac_found > sbi->s_mb_min_to_scan dead check in
> ext4_mb_check_limits
> ext4: use best found when complex scan of group finishs
> ext4: remove unnecessary exit_meta_group_info tag
> ext4: remove unnecessary count2 in ext4_free_data_in_buddy
> ext4: remove unnecessary goto in ext4_mb_mark_diskspace_used
> ext4: remove repeat assignment to ac_f_ex
> ext4: remove comment code ext4_discard_preallocations
> ext4: simplify calculation of blkoff in ext4_mb_new_blocks_simple
>
> fs/ext4/mballoc.c | 111 ++++++++++++++++++----------------------------
> 1 file changed, 43 insertions(+), 68 deletions(-)
>
--
Best wishes
Kemeng Shi
next prev parent reply other threads:[~2023-03-10 8:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 17:21 [PATCH v3 00/20] Some bugfix and cleanup to mballoc Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 01/20] ext4: set goal start correctly in ext4_mb_normalize_request Kemeng Shi
2023-03-13 2:07 ` Ritesh Harjani
2023-04-06 5:18 ` [PATCH v3 1/20] " Theodore Ts'o
2023-03-03 17:21 ` [PATCH v3 02/20] ext4: allow to find by goal if EXT4_MB_HINT_GOAL_ONLY is set Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 03/20] ext4: get correct ext4_group_info in ext4_mb_prefetch_fini Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 04/20] ext4: correct calculation of s_mb_preallocated Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 05/20] ext4: correct start of used group pa for debug in ext4_mb_use_group_pa Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 06/20] ext4: protect pa->pa_free in ext4_discard_allocated_blocks Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 07/20] ext4: add missed brelse in ext4_free_blocks_simple Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 08/20] ext4: remove unused return value of ext4_mb_try_best_found and ext4_mb_free_metadata Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 09/20] ext4: Remove unnecessary release when memory allocation failed in ext4_mb_init_cache Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 10/20] ext4: remove unnecessary e4b->bd_buddy_page check in ext4_mb_load_buddy_gfp Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 11/20] ext4: remove unnecessary check in ext4_mb_new_blocks Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 12/20] ext4: remove dead check in mb_buddy_mark_free Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 13/20] ext4: remove ac->ac_found > sbi->s_mb_min_to_scan dead check in ext4_mb_check_limits Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 14/20] ext4: use best found when complex scan of group finishs Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 15/20] ext4: remove unnecessary exit_meta_group_info tag Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 16/20] ext4: remove unnecessary count2 in ext4_free_data_in_buddy Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 17/20] ext4: remove unnecessary goto in ext4_mb_mark_diskspace_used Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 18/20] ext4: remove repeat assignment to ac_f_ex Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 19/20] ext4: remove comment code ext4_discard_preallocations Kemeng Shi
2023-03-03 17:21 ` [PATCH v3 20/20] ext4: simplify calculation of blkoff in ext4_mb_new_blocks_simple Kemeng Shi
2023-03-16 5:07 ` Theodore Ts'o
2023-03-16 10:19 ` Kemeng Shi
2023-03-17 15:50 ` Theodore Ts'o
2023-03-20 7:31 ` Kemeng Shi
2023-03-10 8:17 ` Kemeng Shi [this message]
2023-03-17 1:52 ` [PATCH v3 00/20] Some bugfix and cleanup to mballoc Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e5691cd-3308-be3b-91d5-9fa1ab9ec98d@huaweicloud.com \
--to=shikemeng@huaweicloud.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).