From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15291C35249 for ; Mon, 3 Feb 2020 01:46:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E790D205F4 for ; Mon, 3 Feb 2020 01:46:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727180AbgBCBqI (ORCPT ); Sun, 2 Feb 2020 20:46:08 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:46746 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726971AbgBCBqI (ORCPT ); Sun, 2 Feb 2020 20:46:08 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 085A328BEFA From: Gabriel Krisman Bertazi To: Daniel Rosenberg Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, Alexander Viro , Richard Weinberger , linux-mtd@lists.infradead.org, Andreas Dilger , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v6 1/5] unicode: Add standard casefolded d_ops Organization: Collabora References: <20200128230328.183524-1-drosen@google.com> <20200128230328.183524-2-drosen@google.com> Date: Sun, 02 Feb 2020 20:45:59 -0500 In-Reply-To: <20200128230328.183524-2-drosen@google.com> (Daniel Rosenberg's message of "Tue, 28 Jan 2020 15:03:24 -0800") Message-ID: <85sgjsxx2g.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Daniel Rosenberg writes: > diff --git a/include/linux/unicode.h b/include/linux/unicode.h > index 990aa97d80496..5de313abeaf98 100644 > --- a/include/linux/unicode.h > +++ b/include/linux/unicode.h > @@ -4,6 +4,8 @@ > > #include > #include > +#include > +#include > > struct unicode_map { > const char *charset; > @@ -30,4 +32,19 @@ int utf8_casefold(const struct unicode_map *um, const struct qstr *str, > struct unicode_map *utf8_load(const char *version); > void utf8_unload(struct unicode_map *um); > > +int utf8_ci_d_hash(const struct dentry *dentry, struct qstr *str); > +int utf8_ci_d_compare(const struct dentry *dentry, unsigned int len, > + const char *str, const struct qstr *name); I don't think fs/unicode is the right place for these very specific filesystem functions, just because they happen to use unicode. It is an encoding library, it doesn't care about dentries, nor should know how to handle them. It exposes a simple api to manipulate and convert utf8 strings. I saw change was after the desire to not have these functions polluting the VFS hot path, but that has nothing to do with placing them here. Would libfs be better? or a casefolding library in fs/casefold.c? -- Gabriel Krisman Bertazi