From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: LTP List <ltp@lists.linux.it>, Jan Kara <jack@suse.com>,
Ext4 <linux-ext4@vger.kernel.org>,
Khazhismel Kumykov <khazhy@google.com>,
kernel@collabora.com
Subject: Re: [PATCH 3/7] syscalls/fanotify20: Validate incoming FID in FAN_FS_ERROR
Date: Wed, 04 Aug 2021 00:54:09 -0400 [thread overview]
Message-ID: <87fsvphksu.fsf@collabora.com> (raw)
In-Reply-To: <CAOQ4uxjMfJM4FM4tWJWgjbK4a2K1hNJdEBRvwQTh9+5su2N0Tw@mail.gmail.com> (Amir Goldstein's message of "Tue, 3 Aug 2021 11:56:31 +0300")
Amir Goldstein <amir73il@gmail.com> writes:
> On Tue, Aug 3, 2021 at 12:47 AM Gabriel Krisman Bertazi
> <krisman@collabora.com> wrote:
>>
>> Verify the FID provided in the event. If the testcase has a null inode,
>> this is assumed to be a superblock error (i.e. null FH).
>>
>> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
>> ---
>> .../kernel/syscalls/fanotify/fanotify20.c | 51 +++++++++++++++++++
>> 1 file changed, 51 insertions(+)
>>
>> diff --git a/testcases/kernel/syscalls/fanotify/fanotify20.c b/testcases/kernel/syscalls/fanotify/fanotify20.c
>> index fd5cfb8744f1..d8d788ae685f 100644
>> --- a/testcases/kernel/syscalls/fanotify/fanotify20.c
>> +++ b/testcases/kernel/syscalls/fanotify/fanotify20.c
>> @@ -40,6 +40,14 @@
>>
>> #define FAN_EVENT_INFO_TYPE_ERROR 4
>>
>> +#ifndef FILEID_INVALID
>> +#define FILEID_INVALID 0xff
>> +#endif
>> +
>> +#ifndef FILEID_INO32_GEN
>> +#define FILEID_INO32_GEN 1
>> +#endif
>> +
>> struct fanotify_event_info_error {
>> struct fanotify_event_info_header hdr;
>> __s32 error;
>> @@ -57,6 +65,9 @@ static const struct test_case {
>> char *name;
>> int error;
>> unsigned int error_count;
>> +
>> + /* inode can be null for superblock errors */
>> + unsigned int *inode;
>
> Any reason not to use fanotify_fid_t * like fanotify16.c?
No reason other than I didn't notice they existed. Sorry. I will get
this fixed.
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2021-08-04 4:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 21:46 [PATCH 0/7] Test the new fanotify FAN_FS_ERROR event Gabriel Krisman Bertazi
2021-08-02 21:46 ` [PATCH 1/7] syscalls/fanotify20: Introduce helpers for FAN_FS_ERROR test Gabriel Krisman Bertazi
2021-08-03 8:30 ` Amir Goldstein
2021-08-02 21:46 ` [PATCH 2/7] syscalls/fanotify20: Validate the generic error info Gabriel Krisman Bertazi
2021-08-03 8:42 ` Amir Goldstein
2021-08-02 21:46 ` [PATCH 3/7] syscalls/fanotify20: Validate incoming FID in FAN_FS_ERROR Gabriel Krisman Bertazi
2021-08-03 8:56 ` Amir Goldstein
2021-08-04 4:54 ` Gabriel Krisman Bertazi [this message]
2021-08-04 5:39 ` Amir Goldstein
2021-08-04 7:40 ` Matthew Bobrowski
2021-08-20 10:21 ` [LTP] " Petr Vorel
2021-08-20 21:58 ` Matthew Bobrowski
2021-08-23 9:35 ` Jan Kara
2021-08-23 11:19 ` Matthew Bobrowski
2021-08-23 14:34 ` Gabriel Krisman Bertazi
2021-08-02 21:46 ` [PATCH 4/7] syscalls/fanotify20: Watch event after filesystem abort Gabriel Krisman Bertazi
2021-08-02 21:46 ` [PATCH 5/7] syscalls/fanotify20: Support submission of debugfs commands Gabriel Krisman Bertazi
2021-08-02 21:46 ` [PATCH 6/7] syscalls/fanotify20: Test file event with broken inode Gabriel Krisman Bertazi
2021-08-03 9:04 ` Amir Goldstein
2021-08-03 9:08 ` Amir Goldstein
2021-08-04 4:52 ` Gabriel Krisman Bertazi
2021-08-04 5:27 ` Amir Goldstein
2021-08-05 21:50 ` Gabriel Krisman Bertazi
2021-08-02 21:46 ` [PATCH 7/7] syscalls/fanotify20: Test capture of multiple errors Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsvphksu.fsf@collabora.com \
--to=krisman@collabora.com \
--cc=amir73il@gmail.com \
--cc=jack@suse.com \
--cc=kernel@collabora.com \
--cc=khazhy@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).