e2fsprogs 1.46.2 needs #include <time.h> in probe.c

e2fsprogs 1.46.2 needs #include <time.h> in probe.c

[Ryan Schmidt]

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]

Hi,

I am the maintainer of e2fsprogs in MacPorts. The developer of e2fsprogs has asked me to report patches for his program to this mailing list.

e2fsprogs 1.46.2 does not build on macOS when implicit declaration of functions is considered an error. This condition can be achieved either by adding -Werror=implicit-function-declaration to CFLAGS when configuring or by compiling with the version of clang included with Xcode 12 or later on macOS in which that behavior is the default.

The error messages are:


probe.c:285:16: error: implicit declaration of function 'time' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        time_t          now = time(0);
                              ^
probe.c:1677:9: error: implicit declaration of function 'difftime' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        diff = difftime(now, dev->bid_time);
               ^
2 errors generated.


The fix is to #include <time.h> in probe.c per the attached patch.

This problem and the fix were reported to MacPorts against e2fsprogs 1.45.6 here: https://github.com/macports/macports-ports/pull/9137

Please Cc me on replies if you need further information.


[-- Attachment #2: patch-probe.c.diff --]
[-- Type: application/octet-stream, Size: 282 bytes --]

--- lib/blkid/probe.c	2020-11-15 14:19:10.000000000 -0500
+++ lib/blkid/probe.c.fixed	2020-11-15 14:21:25.000000000 -0500
@@ -17,6 +17,7 @@
 #include <stdio.h>
 #include <string.h>
 #include <stdlib.h>
+#include <time.h>
 #include <unistd.h>
 #include <fcntl.h>
 #include <ctype.h>

Re: e2fsprogs 1.46.2 needs #include <time.h> in probe.c

[Theodore Ts'o]

On Sun, Apr 11, 2021 at 07:57:33AM -0500, Ryan Schmidt wrote:
> Hi,
> 
> I am the maintainer of e2fsprogs in MacPorts. The developer of
> e2fsprogs has asked me to report patches for his program to this
> mailing list.
> 
> e2fsprogs 1.46.2 does not build on macOS when implicit declaration
> of functions is considered an error. This condition can be achieved
> either by adding -Werror=implicit-function-declaration to CFLAGS
> when configuring or by compiling with the version of clang included
> with Xcode 12 or later on macOS in which that behavior is the
> default.

Hi Ryan,

Thanks for the bug report and proposed fix.  I've applied it to the
e2fsprogs git tree.

Cheers,

					- Ted