From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4A7BC433E7 for ; Sat, 10 Oct 2020 03:54:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 477DC2063A for ; Sat, 10 Oct 2020 03:54:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MNCmMBh0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730801AbgJJDyU (ORCPT ); Fri, 9 Oct 2020 23:54:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730920AbgJJDkH (ORCPT ); Fri, 9 Oct 2020 23:40:07 -0400 Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2755C0613D5; Fri, 9 Oct 2020 20:14:46 -0700 (PDT) Received: by mail-il1-x144.google.com with SMTP id b2so11096470ilr.1; Fri, 09 Oct 2020 20:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=T7Myh5hgefype84ZyMTWFL+NtDFSpEcH4wo+XsH3jtQ=; b=MNCmMBh0nWrAYMKKoAx4eS7NfaPNChxqxhLdAm9sulOeMpf6bkovUeJr0FxJS17RIn 4ooyRIZKarHD2Kix/3dyzHO20bgrVpCGjCu9Bmpc2E+sPg1BEv4NeepJACatvCDk3Lhu 2vCy5puDd518jf/Crd0i/fFayus4L7Eq1CeUfnv8BNuue2d/ClQyXGJ0LDUSqS+dInBy LLnGyDr8WMjj9mSyrg5Qm7SeB8tEXTv/d+J48g70pHWCaEdvJ363LWCg4UVXUoWpLAoX dmM8MU+4kQlzTtMKdQzhFIIPo04LqkTQHevzTAqCW7os/c+JWJTeVBWNSJrdCLWaNuYa MUnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=T7Myh5hgefype84ZyMTWFL+NtDFSpEcH4wo+XsH3jtQ=; b=J7jZcGKEd9QfiDDST4ZO4qNm4QyG5bJ8+AeIwndKHlHGEWi5nzNflEfsjhz2iLw25S 00uHEiW+ZiORPepFALJd22+Vb6PzDzNPggcBLZAiJp4FBKgQI81zruajfPWp/lCBK2xI cVZMyjQDyRvcm5c4HmETvfeC2gstWvJIY6JCYqNgfTlnQt0zgJRbGK0L/mDpJdJ9LBYP oagtubVxKrGP9DEZbiSBbtfU8aNOE7Tk4tf7oHVydsjReH0ck4a73B8Hd0NNX8b62MCB 6uu04iAvUrZXAOH+Uo71urI1ABZysH9v1y4SiignbAYMKFSJ+5gWzIBVJLmdLK+VM+Zs s28g== X-Gm-Message-State: AOAM531xPtLT86xBI4XNGr4pNM3M0vMLinxj4NF+egUpCLURMa/Z5tHB EIC37Q2b+i8VeYFCubbccf4IXJ+lXxWJUvFz/8A= X-Google-Smtp-Source: ABdhPJyxyYLeir1BqAKEnwMZxKnbPy7MAILD6FH40v7zuua0vIS2AnLIq1apl8bx+B/BezlNy0Mq3YMJeaRWYyUMesA= X-Received: by 2002:a92:c986:: with SMTP id y6mr12182206iln.10.1602299686242; Fri, 09 Oct 2020 20:14:46 -0700 (PDT) MIME-Version: 1.0 References: <20201009154509.GK235506@mit.edu> In-Reply-To: Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Sat, 10 Oct 2020 05:14:31 +0200 Message-ID: Subject: Re: ext4: dev: Broken with CONFIG_JBD2=and CONFIG_EXT4_FS=m To: harshad shirwadkar Cc: "Theodore Y. Ts'o" , Ext4 Developers List , linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Oct 9, 2020 at 6:04 PM harshad shirwadkar wrote: > > Thanks Sedat for pointing that out and also sending out the fixes. > Ted, should I send out another version of fast commits out with > Sedat's fixes? > Hi Harshad, when you work on v10, can you look at these warnings, please? fs/jbd2/recovery.c:241:15: warning: unused variable 'seq' [-Wunused-variable] fs/ext4/fast_commit.c:1091:6: warning: variable 'start_time' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] fs/ext4/fast_commit.c:1091:6: warning: variable 'start_time' is used uninitialized whenever '||' condition is true [-Wsometimes-uninitialized] Thanks, - Sedat - P.S.: Now, I see that ext4.git#dev has dropped the hs/fast-commit v9 merge. > > > On Fri, Oct 9, 2020 at 8:45 AM Theodore Y. Ts'o wrote: > > > > On Fri, Oct 09, 2020 at 04:31:51PM +0200, Sedat Dilek wrote: > > > > This fixes it... > > > > Sedat, > > > > Thanks for the report and the proposed fixes! > > > > - Ted