linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sedat Dilek <sedat.dilek@gmail.com>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: ext4: dev: Broken with CONFIG_JBD2=and CONFIG_EXT4_FS=m
Date: Fri, 9 Oct 2020 16:10:15 +0200	[thread overview]
Message-ID: <CA+icZUVd6nf-LmoHB18vsZZjprDGW6nVFNKW3b9_cwxWvbTejw@mail.gmail.com> (raw)
In-Reply-To: <CA+icZUWkE5CVtGGo88zo9b28JB1rN7=Gpc4hXywUaqjdCcSyOw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2305 bytes --]

On Fri, Oct 9, 2020 at 3:49 PM Sedat Dilek <sedat.dilek@gmail.com> wrote:
>
> Hi Ted,
>
> with <ext4.git#dev> up to commit
> ab7b179af3f98772f2433ddc4ace6b7924a4e862 ("Merge branch
> 'hs/fast-commit-v9' into dev") I see some warnings (were reported via
> kernel-test-bot)...
>
> fs/jbd2/recovery.c:241:15: warning: unused variable 'seq' [-Wunused-variable]
> fs/ext4/fast_commit.c:1091:6: warning: variable 'start_time' is used
> uninitialized whenever 'if' condition is true
> [-Wsometimes-uninitialized]
> fs/ext4/fast_commit.c:1091:6: warning: variable 'start_time' is used
> uninitialized whenever '||' condition is true
> [-Wsometimes-uninitialized]
>
> ...and more severe a build breakage with CONFIG_JBD2=and CONFIG_EXT4_FS=m
>
> ERROR: modpost: "jbd2_fc_release_bufs" [fs/ext4/ext4.ko] undefined!
> ERROR: modpost: "jbd2_fc_init" [fs/ext4/ext4.ko] undefined!
> ERROR: modpost: "jbd2_fc_stop_do_commit" [fs/ext4/ext4.ko] undefined!
> ERROR: modpost: "jbd2_fc_stop" [fs/ext4/ext4.ko] undefined!
> ERROR: modpost: "jbd2_fc_start" [fs/ext4/ext4.ko] undefined!
>
> Looks like missing exports.
>

This fixes it...

$ git diff
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 8a51c1ad7088..e50aeefaa217 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -754,6 +754,7 @@ int jbd2_fc_start(journal_t *journal, tid_t tid)

       return 0;
}
+EXPORT_SYMBOL(jbd2_fc_start);

/*
 * Stop a fast commit. If fallback is set, this function starts commit of
@@ -778,11 +779,13 @@ int jbd2_fc_stop(journal_t *journal)
{
       return __jbd2_fc_stop(journal, 0, 0);
}
+EXPORT_SYMBOL(jbd2_fc_stop);

int jbd2_fc_stop_do_commit(journal_t *journal, tid_t tid)
{
       return __jbd2_fc_stop(journal, tid, 1);
}
+EXPORT_SYMBOL(jbd2_fc_stop_do_commit);

/* Return 1 when transaction with given tid has already committed. */
int jbd2_transaction_committed(journal_t *journal, tid_t tid)
@@ -954,6 +957,7 @@ int jbd2_fc_release_bufs(journal_t *journal)

       return 0;
}
+EXPORT_SYMBOL(jbd2_fc_release_bufs);

/*
 * Conversion of logical to physical block numbers for the journal
@@ -1389,6 +1393,7 @@ int jbd2_fc_init(journal_t *journal, int num_fc_blks)
               return -ENOMEM;
       return 0;
}
+EXPORT_SYMBOL(jbd2_fc_init);

/* jbd2_journal_init_dev and jbd2_journal_init_inode:
 *

- Sedat -

[-- Attachment #2: jbd2-journal-fix-build-when-CONFIG_EXT4-as-module.diff --]
[-- Type: text/x-patch, Size: 1152 bytes --]

diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 8a51c1ad7088..e50aeefaa217 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -754,6 +754,7 @@ int jbd2_fc_start(journal_t *journal, tid_t tid)
 
 	return 0;
 }
+EXPORT_SYMBOL(jbd2_fc_start);
 
 /*
  * Stop a fast commit. If fallback is set, this function starts commit of
@@ -778,11 +779,13 @@ int jbd2_fc_stop(journal_t *journal)
 {
 	return __jbd2_fc_stop(journal, 0, 0);
 }
+EXPORT_SYMBOL(jbd2_fc_stop);
 
 int jbd2_fc_stop_do_commit(journal_t *journal, tid_t tid)
 {
 	return __jbd2_fc_stop(journal, tid, 1);
 }
+EXPORT_SYMBOL(jbd2_fc_stop_do_commit);
 
 /* Return 1 when transaction with given tid has already committed. */
 int jbd2_transaction_committed(journal_t *journal, tid_t tid)
@@ -954,6 +957,7 @@ int jbd2_fc_release_bufs(journal_t *journal)
 
 	return 0;
 }
+EXPORT_SYMBOL(jbd2_fc_release_bufs);
 
 /*
  * Conversion of logical to physical block numbers for the journal
@@ -1389,6 +1393,7 @@ int jbd2_fc_init(journal_t *journal, int num_fc_blks)
 		return -ENOMEM;
 	return 0;
 }
+EXPORT_SYMBOL(jbd2_fc_init);
 
 /* jbd2_journal_init_dev and jbd2_journal_init_inode:
  *

  reply	other threads:[~2020-10-09 14:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09 13:49 ext4: dev: Broken with CONFIG_JBD2=and CONFIG_EXT4_FS=m Sedat Dilek
2020-10-09 14:10 ` Sedat Dilek [this message]
2020-10-09 14:31   ` Sedat Dilek
2020-10-09 15:45     ` Theodore Y. Ts'o
2020-10-09 16:03       ` harshad shirwadkar
2020-10-09 16:12         ` Sedat Dilek
2020-10-10  3:14         ` Sedat Dilek
2020-10-13 17:43           ` harshad shirwadkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+icZUVd6nf-LmoHB18vsZZjprDGW6nVFNKW3b9_cwxWvbTejw@mail.gmail.com \
    --to=sedat.dilek@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).