From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E0A3C433E7 for ; Fri, 9 Oct 2020 10:28:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25B5622276 for ; Fri, 9 Oct 2020 10:28:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GzpK03fG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731914AbgJIK2x (ORCPT ); Fri, 9 Oct 2020 06:28:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725979AbgJIK2w (ORCPT ); Fri, 9 Oct 2020 06:28:52 -0400 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 967F1C0613D2; Fri, 9 Oct 2020 03:28:52 -0700 (PDT) Received: by mail-il1-x143.google.com with SMTP id q7so8697920ile.8; Fri, 09 Oct 2020 03:28:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=vl6FnDcmMHotO+NlsI4jNXl/ZZeiSghv4APFCf9brEc=; b=GzpK03fGAvht97i6dy2iGnaeighAj9C5abdcyRyPgOGoeYaZLedkRSfW9g0ipF9LKX Mh9WXoOruyqKeexTE3A9Y5TtpdxMQIQDbiq8GvFPncEf2y+uh5HrHoespBBeYPHJS+et pXyMR58UsdV2/dyEFNf/gSI6ABSgizREbS00/uwosl/uU7DxnVHGsrJzKTxn2W1OczSY 9rCOWWrd5xaCTr0qjnZTvgkzCRbYhX76Faiq88mgMz4REzA5iP8GAjQ0KUXS3j5DL+Do Ic9zwGgaNI/m6V0cHnUxhmb9ynlAbYq4x3AF4O5g+HlqYdhIq6rFo/Q5X5+Qv8SdkMD/ 7U/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=vl6FnDcmMHotO+NlsI4jNXl/ZZeiSghv4APFCf9brEc=; b=HbQv2L+i7nTW0CvwfcR/YoiZCPrf+RTzAQbva9yceeBR6gqZUgNan6v3CMhrrJfgCT b39GNR0Jl3ysiz/TS3Ke3nP0so7W9uUY6nOzUVP+wFF0klCn7wOwUPfI9kqTxfxZbP5G 3DVn+357Pfrvy3cY75/pMefmVQRahwicHiNeomFi/xgkJYcPouF0vodfBKrIpd4j5GeR MQG2OMKoIKCx2kedTop910BwmPX1iQsxygt/pNmcDPJ68DHNrAaWmBkjTiwIepkkUxRO /pP/yAOJNntK3OXAdu8ZXC7SwzxfEWvvU2qWoBF2Z45W9L85em6+xlCC28vQz9++738F ruRg== X-Gm-Message-State: AOAM532GInX6PTqxHh5cgbzHI2jqBsDwZmoQ6TZTQ+I+G1yEDWT978pV UsZlLWAsOk0vAL0q8UibvtkDbi9uM+4BF5an6jD8Y21q08+Mug== X-Google-Smtp-Source: ABdhPJy7eg1DPaXz/9mI1i+aZOhwm8pf/MccLsSeFKJ9jM61qfo8Vv86Aa6Rekv36JHJ2AZALBz8kdCUNp0Adp1Aeww= X-Received: by 2002:a92:3543:: with SMTP id c64mr169470ila.209.1602239331831; Fri, 09 Oct 2020 03:28:51 -0700 (PDT) MIME-Version: 1.0 References: <22e5c5f9-c06b-5c49-d165-8f194aad107b@linux.ibm.com> In-Reply-To: Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Fri, 9 Oct 2020 12:28:40 +0200 Message-ID: Subject: Re: [PATCH 1/1] ext4: Fix bs < ps issue reported with dioread_nolock mount opt To: Ritesh Harjani Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, tytso@mit.edu, jack@suse.cz, anju@linux.vnet.ibm.com, "Aneesh Kumar K . V" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Oct 9, 2020 at 12:18 PM Sedat Dilek wrote: > > On Fri, Oct 9, 2020 at 9:19 AM Ritesh Harjani wrote: > > > > > > > > On 10/9/20 12:16 PM, Sedat Dilek wrote: > > > On Thu, Oct 8, 2020 at 5:56 PM Ritesh Harjani wrote: > > >> > > >> left shifting m_lblk by blkbits was causing value overflow and hence > > >> it was not able to convert unwritten to written extent. > > >> So, make sure we typecast it to loff_t before do left shift operation. > > >> Also in func ext4_convert_unwritten_io_end_vec(), make sure to initialize > > >> ret variable to avoid accidentally returning an uninitialized ret. > > >> > > >> This patch fixes the issue reported in ext4 for bs < ps with > > >> dioread_nolock mount option. > > >> > > >> Fixes: c8cc88163f40df39e50c ("ext4: Add support for blocksize < pagesize in dioread_nolock") > > > > > > Fixes: tag should be 12 digits (see [1]). > > > ( Seen while walking through ext-dev Git commits. ) > > > > > > Thanks Sedat, I guess it should be minimum 12 chars [1] > > > > [1]: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n177 > > > > OK. > > In my ~/.gitconfig: > > [core] > abbrev = 12 > > # Check for 'Fixes:' tag used in the Linux-kernel development process > (Thanks Kalle Valo). > # Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst > # Usage: $ git log --format=fixes | head -5 > [pretty] > fixes = Fixes: %h (\"%s\") > > Hope this is useful for others. > Changed to... Link: https://www.kernel.org/doc/html/latest/process/submitting-patches.html - Sedat -