From: Costa Sapuntzakis <costa@purestorage.com>
To: linux-ext4@vger.kernel.org
Subject: [BUG] invalid superblock checksum possibly due to race
Date: Wed, 24 Jun 2020 16:56:18 -0700 [thread overview]
Message-ID: <CAABuPhaMHu+mmHbVKGt2L0tcE2-EMyd5VWcok7kAfJY3DQ=-vw@mail.gmail.com> (raw)
Our workload: taking snapshots repeatedly of an active ext4 filesystem
(vdbench fwiw). e2fsck discovered a snapshot that had a corrupted
superblock after journal replay. Diffing the corrupted superblock to
the superblock before journal replay revealed that only s_last_orphan
and the checksum had changed.
The following race could explain it:
Thread 1 (T1): ext4_orphan_del -> update s_last_orphan to value A ->
ext4_handle_dirty_super -> ext4_superblock_csum_set -- PAUSE right
before setting es->s_checksum
T2: ext4_orphan_del -> update s_last_orphan to value B ->
ext4_handle_dirty_super -> ext4_superblock_csum_set runs to completion
T1: Resume and assign es->s_checksum
Is there higher level synchronization going on that makes this race benign?
If not, a spinlock around the calculation and assignment should fix it.
The spinlock still has the race where s_last_orphan is being updated
while the checksum is calculated. But the last thread to set
s_last_orphan will also eventually try to recalculate the checksum and
set it right (though it's possible some other thread will do it for
it). And I'm guessing/hoping jbd2 won't flush the superblock to the
journal and close a transaction until the references from
journal_get_write_access drain. The checksum is recalculated before
the get_write_access reference is dropped.
-Costa
next reply other threads:[~2020-06-24 23:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 23:56 Costa Sapuntzakis [this message]
2020-06-30 11:48 ` [BUG] invalid superblock checksum possibly due to race Jan Kara
2020-06-30 18:34 ` Costa Sapuntzakis
2020-07-01 16:22 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAABuPhaMHu+mmHbVKGt2L0tcE2-EMyd5VWcok7kAfJY3DQ=-vw@mail.gmail.com' \
--to=costa@purestorage.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).