From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D31F8C2D0E4 for ; Tue, 24 Nov 2020 07:26:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 694AF20679 for ; Tue, 24 Nov 2020 07:26:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TI1qEy3T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729991AbgKXHZp (ORCPT ); Tue, 24 Nov 2020 02:25:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729955AbgKXHZp (ORCPT ); Tue, 24 Nov 2020 02:25:45 -0500 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98705C0617A6 for ; Mon, 23 Nov 2020 23:25:44 -0800 (PST) Received: by mail-lj1-x241.google.com with SMTP id r18so6084523ljc.2 for ; Mon, 23 Nov 2020 23:25:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H7wcsVmiRBzdbzaU1jn2/D4v2W6wjtxUE3QJby9ONMo=; b=TI1qEy3TmyLIzdKNdJQqeiqUMl+2ELnq3995chqivPaCfj/AzhaKQ+2bIqEmn9sxy8 z0YAtzsPF5XTcrRhQA+dIpONHcVgDybgufVR0123dzPsZB0K5a8zKSbMjCp3dBAMVdz8 qIBxDVo6WQz/LlL+YPoMbaWnug+TJfBTk0es6P72sznSVQnOIILfWRNOU99HrCWhuBgR 602f2fTKn4Cse62ikNeOCdK8TvLEWJh9EBmw3xh5GloadBKmmCpn5hR4SuBxjCfDbi8E q95ub1mUdRvnIs+qIg1wEkdX699lQEAyFKH67Gvm33GRj6e0tZcAjzmE+RrgTTaxgMpP pogg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H7wcsVmiRBzdbzaU1jn2/D4v2W6wjtxUE3QJby9ONMo=; b=Rkjlhrg1zISdir0YJlKUEEeF/w+ukZtB2A8gcjiyzbYchVXy11kqnqyaOKSL9ERxzu 2ak+zvDytH88yN+1aP1L6bwlXKYqop6+gKg9Ka+1HCAjb4wJTTxSK3yEyYQQZ5+kEDZs 7PNOaph1kKDcsOXNcVjfDx9pSYMcUgXRXf8AFiDbIv4SG4LBh0X0KdxZgvFTzAtJA1Ew WSAHLZ7Mdu28mKlQ4Jz/v97s5YJSY0YdYcQG09CR2u8ox4V8dE1BVzobQ7WLQ/ywIigI WeQVd8I99kjz5tJ7L7+iwyYqZLrebOvuFodXSk/eCUzuvG78rNNyrFFvsfyHb87elr19 8lag== X-Gm-Message-State: AOAM531YahZ7+e24wMsecoaN+gGWgt43bj0l1stkDWg+0xDc2KeGhw78 AQLfOJ7mcjrQf720V1qjXRJf09Fsj17SlG8scReTFw== X-Google-Smtp-Source: ABdhPJyUBQdiFImnRxdqaR3qJ7rkDjgJVrH1lMWvXVptsR0064IC5JnBZyuU/OCbvVnd19TaTo3BuNVsIX88yf/i3EA= X-Received: by 2002:a2e:b54b:: with SMTP id a11mr1355573ljn.40.1606202742772; Mon, 23 Nov 2020 23:25:42 -0800 (PST) MIME-Version: 1.0 References: <20201116054035.211498-1-98.arpi@gmail.com> In-Reply-To: From: David Gow Date: Tue, 24 Nov 2020 15:25:30 +0800 Message-ID: Subject: Re: [PATCH v9 1/2] kunit: Support for Parameterized Testing To: Marco Elver , Brendan Higgins , "Theodore Ts'o" , Shuah Khan Cc: Arpitha Raghunandan <98.arpi@gmail.com>, Iurii Zaikin , Andreas Dilger , "Bird, Tim" , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Nov 23, 2020 at 9:08 PM Marco Elver wrote: > > On Tue, 17 Nov 2020 at 08:21, David Gow wrote: > > On Mon, Nov 16, 2020 at 1:41 PM Arpitha Raghunandan <98.arpi@gmail.com> wrote: > > > > > > Implementation of support for parameterized testing in KUnit. This > > > approach requires the creation of a test case using the > > > KUNIT_CASE_PARAM() macro that accepts a generator function as input. > > > > > > This generator function should return the next parameter given the > > > previous parameter in parameterized tests. It also provides a macro to > > > generate common-case generators based on arrays. Generators may also > > > optionally provide a human-readable description of parameters, which is > > > displayed where available. > > > > > > Note, currently the result of each parameter run is displayed in > > > diagnostic lines, and only the overall test case output summarizes > > > TAP-compliant success or failure of all parameter runs. In future, when > > > supported by kunit-tool, these can be turned into subsubtest outputs. > > > > > > Signed-off-by: Arpitha Raghunandan <98.arpi@gmail.com> > > > Co-developed-by: Marco Elver > > > Signed-off-by: Marco Elver > > > --- > > [Resending this because my email client re-defaulted to HTML! Aarrgh!] > > > > This looks good to me! I tested it in UML and x86-64 w/ KASAN, and > > both worked fine. > > > > Reviewed-by: David Gow > > Tested-by: David Gow > > Thank you! > > > Thanks for sticking with this! > > Will these patches be landing in 5.11 or 5.12? > I can't think of any reason not to have these in 5.11. We haven't started staging things in the kselftest/kunit branch for 5.11 yet, though. Patch 2 will probably need to be acked by Ted for ext4 first. Brendan, Shuah: can you make sure this doesn't get lost in patchwork? Cheers, -- David > > -- David > > Thanks, > -- Marco