From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9872BC432C0 for ; Tue, 19 Nov 2019 01:24:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A8C420692 for ; Tue, 19 Nov 2019 01:24:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Uvv+qMR/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727202AbfKSBYr (ORCPT ); Mon, 18 Nov 2019 20:24:47 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:45634 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727126AbfKSBYq (ORCPT ); Mon, 18 Nov 2019 20:24:46 -0500 Received: by mail-pl1-f193.google.com with SMTP id w7so10784366plz.12 for ; Mon, 18 Nov 2019 17:24:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u+EElGaeg7B4NHLzEdMEmecs3hx9HYQQt4MBfsxoGp4=; b=Uvv+qMR/YvSIV89+KOuySyIJSm4e4O8lhyJ4qzs92d2olMqEp9kxbAHwujSp/QcdyY 1ikn1NyGEK1bTHUCPN2ReOTEP4BwNPd/W2fYw82oR5zuyyok3HUHSlXiwDRO5DvqNeQK kXUorqKAnxgoZ+vVnQLRK2tiy77SYX6dLHf7WUdBfG1dFN3EYNwGl1MLezFQtxNfWCeO FKCqQjRgAyWT3IhJ50fwUNjk5H2d5C5PrJ2bWdo8gzNdc1s6uMMEHft0PoI8IRCuCumK UzLRPVaBr4MFBZBOpTZguBQJBX6qjjqVFu0HFirRUDHSE9/fpX4v+Yf0mCoEJpa5jZDq F8eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u+EElGaeg7B4NHLzEdMEmecs3hx9HYQQt4MBfsxoGp4=; b=fp13ZOfQV1qHNnkLWuL3DYszrJiXuchUWguA2pg6PQqvRT04qMb6M5A/75v4GSlM1B 1E5Ei43ItROStSwcGwhcNUHa16FjC1i5Cud1oz/mOGgb1g1s/hsgYeDbE1PG4d4A7IqS hBCFIVPcdAchNY4YHX2BEfI/2QC3oGgaMDZo6jzZtmjsU2MjjRyhs9jGVLLGiADtso1l F/8EtMj43Irv/tFUTkIQPZ2mj5Unq15LW38tf2Drg4iXowwR1okBWaodGf+8Z20hjw6Q ZucV3f9hFW/+S1xDeXrWkoTz8CWMasem5dN+M7DJoI4ETW660z5891Mjuvs+Efophuv/ G3hQ== X-Gm-Message-State: APjAAAVNlPSg8sbjRlUEr4K0oOUiGmWwDkjZNaD80ZtNTemhHK5tKOD6 2USQpLf7YavlJXG3IMziBs3QuKfyrsGdXTS/GAVpwQ== X-Google-Smtp-Source: APXvYqyQ0yIu5BJfhnGVAf7ZY450gOCdnTPdioyEqCBN6cL7YR/zlO5q8oTmMwfOkenfyH5sRhoTBLvV7xDeXBn6IOg= X-Received: by 2002:a17:902:be14:: with SMTP id r20mr31102887pls.297.1574126685459; Mon, 18 Nov 2019 17:24:45 -0800 (PST) MIME-Version: 1.0 References: <1573812972-10529-1-git-send-email-alan.maguire@oracle.com> <1573812972-10529-5-git-send-email-alan.maguire@oracle.com> <20191118220958.GS11244@42.do-not-panic.com> In-Reply-To: <20191118220958.GS11244@42.do-not-panic.com> From: Brendan Higgins Date: Mon, 18 Nov 2019 17:24:33 -0800 Message-ID: Subject: Re: [PATCH v4 linux-kselftest-test 4/6] kunit: remove timeout dependence on sysctl_hung_task_timeout_seconds To: Luis Chamberlain Cc: Alan Maguire , Shuah Khan , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , KUnit Development , Kees Cook , Iurii Zaikin , Andrew Morton , Masahiro Yamada , catalin.marinas@arm.com, joe.lawrence@redhat.com, penguin-kernel@i-love.sakura.ne.jp, schowdary@nvidia.com, urezki@gmail.com, andriy.shevchenko@linux.intel.com, Jonathan Corbet , "Theodore Ts'o" , adilger.kernel@dilger.ca, changbin.du@intel.com, linux-ext4@vger.kernel.org, "open list:DOCUMENTATION" , Stephen Boyd , Knut Omang Content-Type: text/plain; charset="UTF-8" Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Nov 18, 2019 at 2:10 PM Luis Chamberlain wrote: > > On Fri, Nov 15, 2019 at 10:16:10AM +0000, Alan Maguire wrote: > > In discussion of how to handle timeouts, it was noted that if > > sysctl_hung_task_timeout_seconds is exceeded for a kunit test, > > the test task will be killed and an oops generated. This should > > suffice as a means of debugging such timeout issues for now. > > > > Hence remove use of sysctl_hung_task_timeout_secs, which has the > > added benefit of avoiding the need to export that symbol from > > the core kernel. > > > > Signed-off-by: Alan Maguire > > Signed-off-by: Knut Omang > > This seems like a workaround for sysctl_hung_task_timeout_secs not being > exported. If true, this can be addressed by creating a symbol namespace > (new) and using that namespace on this path. It is; as discussed on in v3[1]. I don't really feel strongly one way or the other, I can see arguments for either side. Still, I don't want to give Alan the run-around. I think this is the 3rd or 4th time he has tried to address this issue. [1] https://lore.kernel.org/linux-kselftest/CAFd5g44esDP6WFmkjOiH+my_4iBeqMpFoScMCm_hQ0aFwNS9qw@mail.gmail.com/