From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3079C49ED7 for ; Tue, 17 Sep 2019 01:13:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA74E20678 for ; Tue, 17 Sep 2019 01:13:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568682781; bh=+W2xNDy0Vbt8Lksh920WgCCAU4Gd2hGQK1PfRhxFWPc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=QPGMLFDiomBQ9bdDnAxqSBDzBtwTauTb94Wsk8fRKMVZnHJVayXzd67E4lX9HLusP tLHJ3TpqWsqBb+zIcBbnFau3Uf2/DTPcs+A/a8QZWvT83z8pQHhRdiTq5t/feJ8TBm jExMkH5WDiYLWnkC8yhDmn6iQzmYARCHv5kEAr4M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390580AbfIQBNB (ORCPT ); Mon, 16 Sep 2019 21:13:01 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:39088 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732800AbfIQBNB (ORCPT ); Mon, 16 Sep 2019 21:13:01 -0400 Received: by mail-lj1-f196.google.com with SMTP id s19so1710243lji.6 for ; Mon, 16 Sep 2019 18:12:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lT8XkUtBx2w2E6v7+dJIyb5eDtdCj9FGQxpWjTooN2w=; b=X3PnxylOAF4xYIhV73JftJsYPExC+6nWRgaCoIehOZ0lRHM8e0vtC4kIiCZ0RfabNQ 8bMWtZXCNM/jwB6Es3t2aKnvKb1glk5Zq0J4hLHBdUeNxhEvZaoOd3eWC3odXZrrnc7k FwH8vqjVTIT59p8Zc+gKYzRmiJqlQqh9ZX6P4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lT8XkUtBx2w2E6v7+dJIyb5eDtdCj9FGQxpWjTooN2w=; b=btfBmCVlgaQvaiTAidtGPmHQXToi2D82n1avucgSnyIta8f9X3jPiho5jUCL7BRuF9 4niLE2KOcn7EIcdWbVxxBCfbID4gAyPa3y6+LX950K0V4g1+wSqAC2Eg5iPwTXQO+6PR PpY3rqWcvnNXOtpM4/liYhi169zi5PLApaccHfMBYnl7T5jDQShBH6Mn1YLI80l5yeqJ vzxjnLytUclZaExPlOQ+jJaZxVtxd3tc5Nl67Lyynoz/wfoTvahWAq9NB35ayYYOaUlD E0a7/KFq9JT2FA1WU35sZxo0mSQmWo+PViGmZLO/rB3Cv6RIBrnuV8G537BnKaIef164 Y5nA== X-Gm-Message-State: APjAAAW/UhKeaEe/6dCeMrznHg2UFaMpSERmEdIN3eup3InVjAm+4iBs 6ibmyKzEfjZziAaafyRGVUcGwKWRQnA= X-Google-Smtp-Source: APXvYqwJyb5jqMNv1uPzbhYmqdt2dRR8VRkO7mywD78CP1eq2bkjXpWAJvhnHaE/lyG88sBm7N8vwA== X-Received: by 2002:a2e:8942:: with SMTP id b2mr383470ljk.38.1568682778643; Mon, 16 Sep 2019 18:12:58 -0700 (PDT) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com. [209.85.167.45]) by smtp.gmail.com with ESMTPSA id l3sm90656lfc.31.2019.09.16.18.12.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Sep 2019 18:12:58 -0700 (PDT) Received: by mail-lf1-f45.google.com with SMTP id x80so1460484lff.3 for ; Mon, 16 Sep 2019 18:12:58 -0700 (PDT) X-Received: by 2002:ac2:50cb:: with SMTP id h11mr535207lfm.170.1568682373612; Mon, 16 Sep 2019 18:06:13 -0700 (PDT) MIME-Version: 1.0 References: <20190916042952.GB23719@1wt.eu> <20190916061252.GA24002@1wt.eu> <20190916172117.GB15263@mit.edu> <20190916230217.vmgvsm6o2o4uq5j7@srcf.ucam.org> <20190916231103.bic65ab4ifv7vhio@srcf.ucam.org> <20190916232922.GA7880@darwi-home-pc> In-Reply-To: <20190916232922.GA7880@darwi-home-pc> From: Linus Torvalds Date: Mon, 16 Sep 2019 18:05:57 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Linux 5.3-rc8 To: "Ahmed S. Darwish" Cc: Matthew Garrett , "Theodore Y. Ts'o" , Willy Tarreau , Vito Caputo , Lennart Poettering , Andreas Dilger , Jan Kara , Ray Strode , William Jon McCann , "Alexander E. Patrakov" , zhangjs , linux-ext4@vger.kernel.org, lkml Content-Type: text/plain; charset="UTF-8" Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Archived-At: List-Archive: List-Post: On Mon, Sep 16, 2019 at 4:29 PM Ahmed S. Darwish wrote: > > Linus, in all honesty, the other case is _not_ a hypothetical . Oh yes it is. You're confusing "use" with "breakage". The _use_ of getrandom(0) for key generation isn't hypothetical. But the _breakage_ from the suggested patch that makes it time out is. See the difference? The thing is, to break, you have to (a) do that key generation at boot time (b) do it on an idle machine that doesn't have entropy in order to basically reproduce the current boot-time hang situation with the broken gdm, except with an actual "generate key". Then you have to ignore the big warning too. Linus