From: Wang Shilong <wangshilong1991@gmail.com>
To: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Andreas Dilger <adilger@dilger.ca>, Li Xi <lixi@ddn.com>,
Wang Shilong <wshilong@ddn.com>
Subject: [Project Quota]file owner could change its project ID?
Date: Sat, 12 Oct 2019 14:33:36 +0800 [thread overview]
Message-ID: <CAP9B-QmQ-mbWgJwEWrVOMabsgnPwyJsxSQbMkWuFk81-M4dRPQ@mail.gmail.com> (raw)
Steps to reproduce:
[wangsl@localhost tmp]$ mkdir project
[wangsl@localhost tmp]$ lsattr -p project -d
0 ------------------ project
[wangsl@localhost tmp]$ chattr -p 1 project
[wangsl@localhost tmp]$ lsattr -p -d project
1 ------------------ project
[wangsl@localhost tmp]$ chattr -p 2 project
[wangsl@localhost tmp]$ lsattr -p -d project
2 ------------------ project
[wangsl@localhost tmp]$ df -Th .
Filesystem Type Size Used Avail Use% Mounted on
/dev/sda3 xfs 36G 4.1G 32G 12% /
[wangsl@localhost tmp]$ uname -r
5.4.0-rc2+
As above you could see file owner could change project ID of file its self.
As my understanding, we could set project ID and inherit attribute to account
Directory usage, and implement a similar 'Directory Quota' based on this.
But Directories could easily break this limit by change its file to
other project ID.
And we used vfs_ioc_fssetxattr_check() to only allow init userspace to
change project quota:
/*
* Project Quota ID state is only allowed to change from within the init
* namespace. Enforce that restriction only if we are trying to change
* the quota ID state. Everything else is allowed in user namespaces.
*/
if (current_user_ns() != &init_user_ns) {
if (old_fa->fsx_projid != fa->fsx_projid)
return -EINVAL;
if ((old_fa->fsx_xflags ^ fa->fsx_xflags) &
FS_XFLAG_PROJINHERIT)
return -EINVAL;
}
Shall we have something like following to limit admin change for
Project state too?
diff --git a/fs/inode.c b/fs/inode.c
index fef457a42882..3e324931ee84 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -2273,7 +2273,7 @@ int vfs_ioc_fssetxattr_check(struct inode
*inode, const struct fsxattr *old_fa,
* namespace. Enforce that restriction only if we are trying to change
* the quota ID state. Everything else is allowed in user namespaces.
*/
- if (current_user_ns() != &init_user_ns) {
+ if (current_user_ns() != &init_user_ns || !capable(CAP_SYS_ADMIN)){
if (old_fa->fsx_projid != fa->fsx_projid)
return -EINVAL;
if ((old_fa->fsx_xflags ^ fa->fsx_xflags) &
next reply other threads:[~2019-10-12 6:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 6:33 Wang Shilong [this message]
2019-10-12 20:51 ` [Project Quota]file owner could change its project ID? Dave Chinner
2019-10-13 16:41 ` Darrick J. Wong
2019-10-16 11:51 ` Wang Shilong
2019-10-16 21:22 ` Dave Chinner
2019-10-16 21:37 ` Darrick J. Wong
2019-10-17 0:28 ` Andreas Dilger
2019-10-17 12:12 ` Theodore Y. Ts'o
2019-10-20 20:19 ` Andreas Dilger
2019-10-20 22:25 ` Theodore Y. Ts'o
2019-10-21 21:15 ` Andreas Dilger
2019-10-21 23:35 ` Dave Chinner
2019-10-23 23:01 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP9B-QmQ-mbWgJwEWrVOMabsgnPwyJsxSQbMkWuFk81-M4dRPQ@mail.gmail.com \
--to=wangshilong1991@gmail.com \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lixi@ddn.com \
--cc=wshilong@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).