From: Andreas Dilger <adilger@dilger.ca>
To: Jan Kara <jack@suse.cz>
Cc: Ted Tso <tytso@mit.edu>, linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 3/3] tests: Add tests for ext2fs_link() into htree dir
Date: Thu, 6 Feb 2020 16:04:16 -0700 [thread overview]
Message-ID: <ECC8B296-AB11-46B6-898E-F7A85E8AC1EA@dilger.ca> (raw)
In-Reply-To: <20200206101659.GJ14001@quack2.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]
On Feb 6, 2020, at 3:16 AM, Jan Kara <jack@suse.cz> wrote:
>
> On Wed 05-02-20 11:11:13, Andreas Dilger wrote:
>> On Feb 5, 2020, at 3:01 AM, Jan Kara <jack@suse.cz> wrote:
>>>
>>> Add two tests adding 50000 files into a htree directory to test various
>>> cases of htree modification.
>>
>> Note that there is already tests/f_large_dir that is creating a large
>> directory via debugfs. Maybe that could be extended rather than adding
>> another long-running test to do almost the same thing?
>
> I didn't know tests/f_large_dir exists. Thanks for the pointer. There are
> just two problems with this:
>
> 1) I wanted to test both with & without metadata_csum because the code
> paths are somewhat different.
>
> 2) Currently we don't have implemented conversion of normal dir into
> indexed one so I need to start with a fs image that already has indexed
> directory.
>
> I suppose I could modify tests/f_large_dir to start with an image to
> address 2) if people are OK with that. And I could just create
> tests/f_large_dir_csum to address 1).
This would be quite a large image? I thought "e2fsck -fD" would re-pack
htree directories (via e2fsck/rehash.c), so it seems like you could create
a non-htree test filesystem like f_large_dir, set the feature and inode
flags, and then run e2fsck -fD on it? That would also test the rehash code.
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
next prev parent reply other threads:[~2020-02-06 23:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 10:01 [PATCH 0/3] e2fsprogs: Better handling of indexed directories Jan Kara
2020-02-05 10:01 ` [PATCH 1/3] e2fsck: Clarify overflow link count error message Jan Kara
2020-02-05 17:38 ` Andreas Dilger
2020-02-06 9:59 ` Jan Kara
2020-02-05 10:01 ` [PATCH 2/3] ext2fs: Implement dir entry creation in htree directories Jan Kara
2020-02-05 17:50 ` Andreas Dilger
2020-02-06 10:07 ` Jan Kara
2020-02-05 10:01 ` [PATCH 3/3] tests: Add tests for ext2fs_link() into htree dir Jan Kara
2020-02-05 18:11 ` Andreas Dilger
2020-02-06 10:16 ` Jan Kara
2020-02-06 23:04 ` Andreas Dilger [this message]
2020-02-10 9:18 ` Jan Kara
2020-02-05 15:24 ` [PATCH 0/3] e2fsprogs: Better handling of indexed directories Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ECC8B296-AB11-46B6-898E-F7A85E8AC1EA@dilger.ca \
--to=adilger@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).