* [PATCH 0/8] EXT4: Trivial typo fixes
@ 2021-03-27 10:30 Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 1/8] EXT4: migrate.c: Fixed few typos Bhaskar Chowdhury
` (9 more replies)
0 siblings, 10 replies; 12+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-27 10:30 UTC (permalink / raw)
To: tytso, adilger.kernel
Cc: Bhaskar Chowdhury, linux-ext4, rdunlap, linux-kernel
This patch series fixed few mundane typos in the below specific files.
Bhaskar Chowdhury (8):
EXT4: migrate.c: Fixed few typos
EXT4: namei.c: Fixed a typo
EXT4: inline.c: A typo fixed
Fix a typo
EXT4: indirect.c: A trivial typo fix
EXT4: xattr.c: Mundane typo fix
EXT4: fast_commit.c: A mere typo fix
EXT4: mballoc.h: Single typo fix
fs/ext4/fast_commit.c | 2 +-
fs/ext4/indirect.c | 2 +-
fs/ext4/inline.c | 2 +-
fs/ext4/inode.c | 2 +-
fs/ext4/mballoc.h | 2 +-
fs/ext4/migrate.c | 6 +++---
fs/ext4/namei.c | 8 ++++----
fs/ext4/xattr.c | 2 +-
8 files changed, 13 insertions(+), 13 deletions(-)
--
2.26.2
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/8] EXT4: migrate.c: Fixed few typos
2021-03-27 10:30 [PATCH 0/8] EXT4: Trivial typo fixes Bhaskar Chowdhury
@ 2021-03-27 10:30 ` Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 2/8] EXT4: namei.c: Fixed a typo Bhaskar Chowdhury
` (8 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-27 10:30 UTC (permalink / raw)
To: tytso, adilger.kernel
Cc: Bhaskar Chowdhury, linux-ext4, rdunlap, linux-kernel
s/convinience/convenience/
s/accumalate/accumulate/ .....two differnt places.
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
fs/ext4/migrate.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/migrate.c b/fs/ext4/migrate.c
index c5e3fc998211..7e0b4f81c6c0 100644
--- a/fs/ext4/migrate.c
+++ b/fs/ext4/migrate.c
@@ -32,7 +32,7 @@ static int finish_range(handle_t *handle, struct inode *inode,
newext.ee_block = cpu_to_le32(lb->first_block);
newext.ee_len = cpu_to_le16(lb->last_block - lb->first_block + 1);
ext4_ext_store_pblock(&newext, lb->first_pblock);
- /* Locking only for convinience since we are operating on temp inode */
+ /* Locking only for convenience since we are operating on temp inode */
down_write(&EXT4_I(inode)->i_data_sem);
path = ext4_find_extent(inode, lb->first_block, NULL, 0);
if (IS_ERR(path)) {
@@ -43,8 +43,8 @@ static int finish_range(handle_t *handle, struct inode *inode,
/*
* Calculate the credit needed to inserting this extent
- * Since we are doing this in loop we may accumalate extra
- * credit. But below we try to not accumalate too much
+ * Since we are doing this in loop we may accumulate extra
+ * credit. But below we try to not accumulate too much
* of them by restarting the journal.
*/
needed = ext4_ext_calc_credits_for_single_extent(inode,
--
2.26.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/8] EXT4: namei.c: Fixed a typo
2021-03-27 10:30 [PATCH 0/8] EXT4: Trivial typo fixes Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 1/8] EXT4: migrate.c: Fixed few typos Bhaskar Chowdhury
@ 2021-03-27 10:30 ` Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 3/8] EXT4: inline.c: A typo fixed Bhaskar Chowdhury
` (7 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-27 10:30 UTC (permalink / raw)
To: tytso, adilger.kernel
Cc: Bhaskar Chowdhury, linux-ext4, rdunlap, linux-kernel
s/contiuation/continuation/
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
fs/ext4/namei.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 883e2a7cd4ab..3eb07053ca3c 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -956,7 +956,7 @@ static int ext4_htree_next_block(struct inode *dir, __u32 hash,
* If the hash is 1, then continue only if the next page has a
* continuation hash of any value. This is used for readdir
* handling. Otherwise, check to see if the hash matches the
- * desired contiuation hash. If it doesn't, return since
+ * desired continuation hash. If it doesn't, return since
* there's no point to read in the successive index pages.
*/
bhash = dx_get_hash(p->at);
--
2.26.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/8] EXT4: inline.c: A typo fixed
2021-03-27 10:30 [PATCH 0/8] EXT4: Trivial typo fixes Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 1/8] EXT4: migrate.c: Fixed few typos Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 2/8] EXT4: namei.c: Fixed a typo Bhaskar Chowdhury
@ 2021-03-27 10:30 ` Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 4/8] Fix a typo Bhaskar Chowdhury
` (6 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-27 10:30 UTC (permalink / raw)
To: tytso, adilger.kernel
Cc: Bhaskar Chowdhury, linux-ext4, rdunlap, linux-kernel
s/metatdata/metadata/
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
fs/ext4/inline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index b41512d1badc..fbc5086461e1 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -795,7 +795,7 @@ ext4_journalled_write_inline_data(struct inode *inode,
* clear the inode state safely.
* 2. The inode has inline data, then we need to read the data, make it
* update and dirty so that ext4_da_writepages can handle it. We don't
- * need to start the journal since the file's metatdata isn't changed now.
+ * need to start the journal since the file's metadata isn't changed now.
*/
static int ext4_da_convert_inline_data_to_extent(struct address_space *mapping,
struct inode *inode,
--
2.26.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 4/8] Fix a typo
2021-03-27 10:30 [PATCH 0/8] EXT4: Trivial typo fixes Bhaskar Chowdhury
` (2 preceding siblings ...)
2021-03-27 10:30 ` [PATCH 3/8] EXT4: inline.c: A typo fixed Bhaskar Chowdhury
@ 2021-03-27 10:30 ` Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 5/8] EXT4: indirect.c: A trivial typo fix Bhaskar Chowdhury
` (5 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-27 10:30 UTC (permalink / raw)
To: tytso, adilger.kernel
Cc: Bhaskar Chowdhury, linux-ext4, rdunlap, linux-kernel
s/cooresponds/corresponds/
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
fs/ext4/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 0948a43f1b3d..470d310b9b77 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -3824,7 +3824,7 @@ static int __ext4_block_zero_page_range(handle_t *handle,
* starting from file offset 'from'. The range to be zero'd must
* be contained with in one block. If the specified range exceeds
* the end of the block it will be shortened to end of the block
- * that cooresponds to 'from'
+ * that corresponds to 'from'
*/
static int ext4_block_zero_page_range(handle_t *handle,
struct address_space *mapping, loff_t from, loff_t length)
--
2.26.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 5/8] EXT4: indirect.c: A trivial typo fix
2021-03-27 10:30 [PATCH 0/8] EXT4: Trivial typo fixes Bhaskar Chowdhury
` (3 preceding siblings ...)
2021-03-27 10:30 ` [PATCH 4/8] Fix a typo Bhaskar Chowdhury
@ 2021-03-27 10:30 ` Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 6/8] EXT4: xattr.c: Mundane " Bhaskar Chowdhury
` (4 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-27 10:30 UTC (permalink / raw)
To: tytso, adilger.kernel
Cc: Bhaskar Chowdhury, linux-ext4, rdunlap, linux-kernel
s/conventient/convenient/
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
fs/ext4/indirect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/indirect.c b/fs/ext4/indirect.c
index 1223a18c3ff9..a7bc6ad656a9 100644
--- a/fs/ext4/indirect.c
+++ b/fs/ext4/indirect.c
@@ -705,7 +705,7 @@ static int ext4_ind_trunc_restart_fn(handle_t *handle, struct inode *inode,
/*
* Truncate transactions can be complex and absolutely huge. So we need to
- * be able to restart the transaction at a conventient checkpoint to make
+ * be able to restart the transaction at a convenient checkpoint to make
* sure we don't overflow the journal.
*
* Try to extend this transaction for the purposes of truncation. If
--
2.26.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 6/8] EXT4: xattr.c: Mundane typo fix
2021-03-27 10:30 [PATCH 0/8] EXT4: Trivial typo fixes Bhaskar Chowdhury
` (4 preceding siblings ...)
2021-03-27 10:30 ` [PATCH 5/8] EXT4: indirect.c: A trivial typo fix Bhaskar Chowdhury
@ 2021-03-27 10:30 ` Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 7/8] EXT4: fast_commit.c: A mere " Bhaskar Chowdhury
` (3 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-27 10:30 UTC (permalink / raw)
To: tytso, adilger.kernel
Cc: Bhaskar Chowdhury, linux-ext4, rdunlap, linux-kernel
s/futher/further/
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
fs/ext4/xattr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index 6c1018223c54..10ba4b24a0aa 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -1617,7 +1617,7 @@ static int ext4_xattr_set_entry(struct ext4_xattr_info *i,
* If storing the value in an external inode is an option,
* reserve space for xattr entries/names in the external
* attribute block so that a long value does not occupy the
- * whole space and prevent futher entries being added.
+ * whole space and prevent further entries being added.
*/
if (ext4_has_feature_ea_inode(inode->i_sb) &&
new_size && is_block &&
--
2.26.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 7/8] EXT4: fast_commit.c: A mere typo fix
2021-03-27 10:30 [PATCH 0/8] EXT4: Trivial typo fixes Bhaskar Chowdhury
` (5 preceding siblings ...)
2021-03-27 10:30 ` [PATCH 6/8] EXT4: xattr.c: Mundane " Bhaskar Chowdhury
@ 2021-03-27 10:30 ` Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 8/8] EXT4: mballoc.h: Single " Bhaskar Chowdhury
` (2 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-27 10:30 UTC (permalink / raw)
To: tytso, adilger.kernel
Cc: Bhaskar Chowdhury, linux-ext4, rdunlap, linux-kernel
s/ineligiblity/ineligibility/
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
fs/ext4/fast_commit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
index 7541d0b5d706..8691634044e3 100644
--- a/fs/ext4/fast_commit.c
+++ b/fs/ext4/fast_commit.c
@@ -66,7 +66,7 @@
* Fast Commit Ineligibility
* -------------------------
* Not all operations are supported by fast commits today (e.g extended
- * attributes). Fast commit ineligiblity is marked by calling one of the
+ * attributes). Fast commit ineligibility is marked by calling one of the
* two following functions:
*
* - ext4_fc_mark_ineligible(): This makes next fast commit operation to fall
--
2.26.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 8/8] EXT4: mballoc.h: Single typo fix
2021-03-27 10:30 [PATCH 0/8] EXT4: Trivial typo fixes Bhaskar Chowdhury
` (6 preceding siblings ...)
2021-03-27 10:30 ` [PATCH 7/8] EXT4: fast_commit.c: A mere " Bhaskar Chowdhury
@ 2021-03-27 10:30 ` Bhaskar Chowdhury
2021-03-28 19:37 ` [PATCH 0/8] EXT4: Trivial typo fixes Ritesh Harjani
2021-04-10 3:19 ` Theodore Ts'o
9 siblings, 0 replies; 12+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-27 10:30 UTC (permalink / raw)
To: tytso, adilger.kernel
Cc: Bhaskar Chowdhury, linux-ext4, rdunlap, linux-kernel
s/parition/partition/
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
fs/ext4/mballoc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h
index e75b4749aa1c..7be6288e48ec 100644
--- a/fs/ext4/mballoc.h
+++ b/fs/ext4/mballoc.h
@@ -59,7 +59,7 @@
* by the stream allocator, which purpose is to pack requests
* as close each to other as possible to produce smooth I/O traffic
* We use locality group prealloc space for stream request.
- * We can tune the same via /proc/fs/ext4/<parition>/stream_req
+ * We can tune the same via /proc/fs/ext4/<partition>/stream_req
*/
#define MB_DEFAULT_STREAM_THRESHOLD 16 /* 64K */
--
2.26.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 0/8] EXT4: Trivial typo fixes
2021-03-27 10:30 [PATCH 0/8] EXT4: Trivial typo fixes Bhaskar Chowdhury
` (7 preceding siblings ...)
2021-03-27 10:30 ` [PATCH 8/8] EXT4: mballoc.h: Single " Bhaskar Chowdhury
@ 2021-03-28 19:37 ` Ritesh Harjani
2021-03-28 20:55 ` Bhaskar Chowdhury
2021-04-10 3:19 ` Theodore Ts'o
9 siblings, 1 reply; 12+ messages in thread
From: Ritesh Harjani @ 2021-03-28 19:37 UTC (permalink / raw)
To: Bhaskar Chowdhury
Cc: tytso, adilger.kernel, linux-ext4, rdunlap, linux-kernel
On 21/03/27 04:00PM, Bhaskar Chowdhury wrote:
> This patch series fixed few mundane typos in the below specific files.
>
> Bhaskar Chowdhury (8):
> EXT4: migrate.c: Fixed few typos
> EXT4: namei.c: Fixed a typo
> EXT4: inline.c: A typo fixed
> Fix a typo
> EXT4: indirect.c: A trivial typo fix
> EXT4: xattr.c: Mundane typo fix
> EXT4: fast_commit.c: A mere typo fix
> EXT4: mballoc.h: Single typo fix
>
> fs/ext4/fast_commit.c | 2 +-
> fs/ext4/indirect.c | 2 +-
> fs/ext4/inline.c | 2 +-
> fs/ext4/inode.c | 2 +-
> fs/ext4/mballoc.h | 2 +-
> fs/ext4/migrate.c | 6 +++---
> fs/ext4/namei.c | 8 ++++----
> fs/ext4/xattr.c | 2 +-
> 8 files changed, 13 insertions(+), 13 deletions(-)
Thanks,
since these are trivial typo fixes, why not just 1 patch for fs/ext4/
IMO, that way it is easier for sender, reviewer and maintainer.
-ritesh
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/8] EXT4: Trivial typo fixes
2021-03-28 19:37 ` [PATCH 0/8] EXT4: Trivial typo fixes Ritesh Harjani
@ 2021-03-28 20:55 ` Bhaskar Chowdhury
0 siblings, 0 replies; 12+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-28 20:55 UTC (permalink / raw)
To: Ritesh Harjani; +Cc: tytso, adilger.kernel, linux-ext4, rdunlap, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]
On 01:07 Mon 29 Mar 2021, Ritesh Harjani wrote:
>On 21/03/27 04:00PM, Bhaskar Chowdhury wrote:
>> This patch series fixed few mundane typos in the below specific files.
>>
>> Bhaskar Chowdhury (8):
>> EXT4: migrate.c: Fixed few typos
>> EXT4: namei.c: Fixed a typo
>> EXT4: inline.c: A typo fixed
>> Fix a typo
>> EXT4: indirect.c: A trivial typo fix
>> EXT4: xattr.c: Mundane typo fix
>> EXT4: fast_commit.c: A mere typo fix
>> EXT4: mballoc.h: Single typo fix
>>
>> fs/ext4/fast_commit.c | 2 +-
>> fs/ext4/indirect.c | 2 +-
>> fs/ext4/inline.c | 2 +-
>> fs/ext4/inode.c | 2 +-
>> fs/ext4/mballoc.h | 2 +-
>> fs/ext4/migrate.c | 6 +++---
>> fs/ext4/namei.c | 8 ++++----
>> fs/ext4/xattr.c | 2 +-
>> 8 files changed, 13 insertions(+), 13 deletions(-)
>
>Thanks,
>since these are trivial typo fixes, why not just 1 patch for fs/ext4/
>IMO, that way it is easier for sender, reviewer and maintainer.
>
I have got the other vibes too ..hence the decision to send it like this way..
~Bhaskar
>-ritesh
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/8] EXT4: Trivial typo fixes
2021-03-27 10:30 [PATCH 0/8] EXT4: Trivial typo fixes Bhaskar Chowdhury
` (8 preceding siblings ...)
2021-03-28 19:37 ` [PATCH 0/8] EXT4: Trivial typo fixes Ritesh Harjani
@ 2021-04-10 3:19 ` Theodore Ts'o
9 siblings, 0 replies; 12+ messages in thread
From: Theodore Ts'o @ 2021-04-10 3:19 UTC (permalink / raw)
To: Bhaskar Chowdhury; +Cc: adilger.kernel, linux-ext4, rdunlap, linux-kernel
On Sat, Mar 27, 2021 at 04:00:04PM +0530, Bhaskar Chowdhury wrote:
> This patch series fixed few mundane typos in the below specific files.
>
> Bhaskar Chowdhury (8):
> EXT4: migrate.c: Fixed few typos
> EXT4: namei.c: Fixed a typo
> EXT4: inline.c: A typo fixed
> Fix a typo
> EXT4: indirect.c: A trivial typo fix
> EXT4: xattr.c: Mundane typo fix
> EXT4: fast_commit.c: A mere typo fix
> EXT4: mballoc.h: Single typo fix
>
> fs/ext4/fast_commit.c | 2 +-
> fs/ext4/indirect.c | 2 +-
> fs/ext4/inline.c | 2 +-
> fs/ext4/inode.c | 2 +-
> fs/ext4/mballoc.h | 2 +-
> fs/ext4/migrate.c | 6 +++---
> fs/ext4/namei.c | 8 ++++----
> fs/ext4/xattr.c | 2 +-
> 8 files changed, 13 insertions(+), 13 deletions(-)
I've applied this patch series folded together into a single patch.
- Ted
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-04-10 3:19 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-27 10:30 [PATCH 0/8] EXT4: Trivial typo fixes Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 1/8] EXT4: migrate.c: Fixed few typos Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 2/8] EXT4: namei.c: Fixed a typo Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 3/8] EXT4: inline.c: A typo fixed Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 4/8] Fix a typo Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 5/8] EXT4: indirect.c: A trivial typo fix Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 6/8] EXT4: xattr.c: Mundane " Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 7/8] EXT4: fast_commit.c: A mere " Bhaskar Chowdhury
2021-03-27 10:30 ` [PATCH 8/8] EXT4: mballoc.h: Single " Bhaskar Chowdhury
2021-03-28 19:37 ` [PATCH 0/8] EXT4: Trivial typo fixes Ritesh Harjani
2021-03-28 20:55 ` Bhaskar Chowdhury
2021-04-10 3:19 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).