From: "Theodore Ts'o" <tytso@mit.edu>
To: Haotian Li <lihaotian9@huawei.com>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
"harshad shirwadkar," <harshadshirwadkar@gmail.com>,
"liuzhiqiang (I)" <liuzhiqiang26@huawei.com>,
linfeilong <linfeilong@huawei.com>
Subject: Re: [PATCH] e2fsprogs: Try again to solve unreliable io case
Date: Tue, 20 Apr 2021 12:19:27 -0400 [thread overview]
Message-ID: <YH7/D1h5r9WB1TNq@mit.edu> (raw)
In-Reply-To: <d4fd737d-4280-1aee-32ae-36b303e6644d@huawei.com>
On Tue, Apr 20, 2021 at 03:18:05PM +0800, Haotian Li wrote:
> If some I/O error occured during e2fsck, for example the
> fibre channel connections are flasky, the e2fsck may exit.
> Try again in these I/O error cases may help e2fsck
> successfully execute and fix the disk correctly.
Why not fix this by retrying in the device driver instead? If the
Fibre Channel is that flaky, then it's going to be a problem when the
file system is mounted, so it would seem to me that fixing this in the
kernel makes a lot more sense.
- Ted
next prev parent reply other threads:[~2021-04-20 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 7:18 [PATCH] e2fsprogs: Try again to solve unreliable io case Haotian Li
2021-04-20 15:08 ` Darrick J. Wong
2021-04-22 13:03 ` Zhiqiang Liu
2021-04-20 16:19 ` Theodore Ts'o [this message]
2021-04-23 2:18 ` Zhiqiang Liu
2021-04-23 15:46 ` Theodore Ts'o
2021-04-24 4:46 ` Zhiqiang Liu
2021-05-10 3:35 ` Zhiqiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH7/D1h5r9WB1TNq@mit.edu \
--to=tytso@mit.edu \
--cc=harshadshirwadkar@gmail.com \
--cc=lihaotian9@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).