From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 349FFC433B4 for ; Tue, 20 Apr 2021 16:19:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E792961104 for ; Tue, 20 Apr 2021 16:19:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233090AbhDTQUT (ORCPT ); Tue, 20 Apr 2021 12:20:19 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:51393 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232174AbhDTQUR (ORCPT ); Tue, 20 Apr 2021 12:20:17 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 13KGJRcM002876 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Apr 2021 12:19:27 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 0FA6615C3B0D; Tue, 20 Apr 2021 12:19:27 -0400 (EDT) Date: Tue, 20 Apr 2021 12:19:27 -0400 From: "Theodore Ts'o" To: Haotian Li Cc: Ext4 Developers List , "harshad shirwadkar," , "liuzhiqiang (I)" , linfeilong Subject: Re: [PATCH] e2fsprogs: Try again to solve unreliable io case Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Apr 20, 2021 at 03:18:05PM +0800, Haotian Li wrote: > If some I/O error occured during e2fsck, for example the > fibre channel connections are flasky, the e2fsck may exit. > Try again in these I/O error cases may help e2fsck > successfully execute and fix the disk correctly. Why not fix this by retrying in the device driver instead? If the Fibre Channel is that flaky, then it's going to be a problem when the file system is mounted, so it would seem to me that fixing this in the kernel makes a lot more sense. - Ted