* [PATCH] ext4: Delete redundant uptodate check for buffer
@ 2021-04-01 7:03 Shaokun Zhang
2021-04-01 11:20 ` Ritesh Harjani
0 siblings, 1 reply; 3+ messages in thread
From: Shaokun Zhang @ 2021-04-01 7:03 UTC (permalink / raw)
To: linux-ext4, linux-kernel
Cc: Yang Guo, Theodore Ts'o, Andreas Dilger, Shaokun Zhang
From: Yang Guo <guoyang2@huawei.com>
The buffer uptodate state has been checked in function set_buffer_uptodate,
there is no need use buffer_uptodate before calling set_buffer_uptodate and
delete it.
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Signed-off-by: Yang Guo <guoyang2@huawei.com>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
fs/ext4/inode.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 0948a43f1b3d..32fa3ad38797 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -1066,8 +1066,7 @@ static int ext4_block_write_begin(struct page *page, loff_t pos, unsigned len,
block_end = block_start + blocksize;
if (block_end <= from || block_start >= to) {
if (PageUptodate(page)) {
- if (!buffer_uptodate(bh))
- set_buffer_uptodate(bh);
+ set_buffer_uptodate(bh);
}
continue;
}
@@ -1092,8 +1091,7 @@ static int ext4_block_write_begin(struct page *page, loff_t pos, unsigned len,
}
}
if (PageUptodate(page)) {
- if (!buffer_uptodate(bh))
- set_buffer_uptodate(bh);
+ set_buffer_uptodate(bh);
continue;
}
if (!buffer_uptodate(bh) && !buffer_delay(bh) &&
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: Delete redundant uptodate check for buffer
2021-04-01 7:03 [PATCH] ext4: Delete redundant uptodate check for buffer Shaokun Zhang
@ 2021-04-01 11:20 ` Ritesh Harjani
2021-04-09 16:55 ` Theodore Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Ritesh Harjani @ 2021-04-01 11:20 UTC (permalink / raw)
To: Shaokun Zhang
Cc: linux-ext4, linux-kernel, Yang Guo, Theodore Ts'o,
Andreas Dilger, Ritesh Harjani
On 21/04/01 03:03PM, Shaokun Zhang wrote:
> From: Yang Guo <guoyang2@huawei.com>
>
> The buffer uptodate state has been checked in function set_buffer_uptodate,
> there is no need use buffer_uptodate before calling set_buffer_uptodate and
> delete it.
>
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> Signed-off-by: Yang Guo <guoyang2@huawei.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
> fs/ext4/inode.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Thanks for the patch. Changes looks good and trivial.
Feel free to add -
Reviewed-by: Ritesh Harjani <ritesh.list@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: Delete redundant uptodate check for buffer
2021-04-01 11:20 ` Ritesh Harjani
@ 2021-04-09 16:55 ` Theodore Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2021-04-09 16:55 UTC (permalink / raw)
To: Ritesh Harjani
Cc: Shaokun Zhang, linux-ext4, linux-kernel, Yang Guo, Andreas Dilger
On Thu, Apr 01, 2021 at 04:50:01PM +0530, Ritesh Harjani wrote:
> On 21/04/01 03:03PM, Shaokun Zhang wrote:
> > From: Yang Guo <guoyang2@huawei.com>
> >
> > The buffer uptodate state has been checked in function set_buffer_uptodate,
> > there is no need use buffer_uptodate before calling set_buffer_uptodate and
> > delete it.
> >
> > Cc: "Theodore Ts'o" <tytso@mit.edu>
> > Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> > Signed-off-by: Yang Guo <guoyang2@huawei.com>
> > Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> > ---
> > fs/ext4/inode.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
>
> Thanks for the patch. Changes looks good and trivial.
>
> Feel free to add -
> Reviewed-by: Ritesh Harjani <ritesh.list@gmail.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-09 16:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01 7:03 [PATCH] ext4: Delete redundant uptodate check for buffer Shaokun Zhang
2021-04-01 11:20 ` Ritesh Harjani
2021-04-09 16:55 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).