linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org, Hao Sun <sunhao.th@gmail.com>
Subject: Re: [PATCH 2/2] ext4: Annotate data race in jbd2_journal_dirty_metadata()
Date: Fri, 9 Apr 2021 21:24:19 -0400	[thread overview]
Message-ID: <YHD+Q4NdOQ7j7doW@mit.edu> (raw)
In-Reply-To: <20210406161804.20150-2-jack@suse.cz>

On Tue, Apr 06, 2021 at 06:18:00PM +0200, Jan Kara wrote:
> Assertion checks in jbd2_journal_dirty_metadata() are known to be racy
> but we don't want to be grabbing locks just for them.  We thus recheck
> them under b_state_lock only if it looks like they would fail. Annotate
> the checks with data_race().
> 
> Reported-by: Hao Sun <sunhao.th@gmail.com>
> Signed-off-by: Jan Kara <jack@suse.cz>

Thanks, applied.

					- Ted

      reply	other threads:[~2021-04-10  1:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06 16:17 [PATCH 0/2] ext4: Annotate two harmless KCSAN data races Jan Kara
2021-04-06 16:17 ` [PATCH 1/2] ext4: Annotate data race in start_this_handle() Jan Kara
2021-04-10  1:24   ` Theodore Ts'o
2021-04-06 16:18 ` [PATCH 2/2] ext4: Annotate data race in jbd2_journal_dirty_metadata() Jan Kara
2021-04-10  1:24   ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHD+Q4NdOQ7j7doW@mit.edu \
    --to=tytso@mit.edu \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sunhao.th@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).