From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A9E8C433ED for ; Sun, 11 Apr 2021 23:58:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CABB61205 for ; Sun, 11 Apr 2021 23:58:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235853AbhDKX7B (ORCPT ); Sun, 11 Apr 2021 19:59:01 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:38329 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235722AbhDKX7A (ORCPT ); Sun, 11 Apr 2021 19:59:00 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 13BNwYsK027373 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 11 Apr 2021 19:58:35 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 6211D15C3B0D; Sun, 11 Apr 2021 19:58:34 -0400 (EDT) Date: Sun, 11 Apr 2021 19:58:34 -0400 From: "Theodore Ts'o" To: Ryan Schmidt Cc: linux-ext4@vger.kernel.org Subject: Re: e2fsprogs 1.46.2 needs #include in probe.c Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sun, Apr 11, 2021 at 07:57:33AM -0500, Ryan Schmidt wrote: > Hi, > > I am the maintainer of e2fsprogs in MacPorts. The developer of > e2fsprogs has asked me to report patches for his program to this > mailing list. > > e2fsprogs 1.46.2 does not build on macOS when implicit declaration > of functions is considered an error. This condition can be achieved > either by adding -Werror=implicit-function-declaration to CFLAGS > when configuring or by compiling with the version of clang included > with Xcode 12 or later on macOS in which that behavior is the > default. Hi Ryan, Thanks for the bug report and proposed fix. I've applied it to the e2fsprogs git tree. Cheers, - Ted