From: Greg KH <gregkh@linuxfoundation.org>
To: Nico Pache <npache@redhat.com>
Cc: linux-kernel@vger.kernel.org, brendanhiggins@google.com,
linux-ext4@vger.kernel.org, netdev@vger.kernel.org,
rafael@kernel.org, linux-m68k@lists.linux-m68k.org,
geert@linux-m68k.org
Subject: Re: [PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the standard
Date: Wed, 14 Apr 2021 07:50:45 +0200 [thread overview]
Message-ID: <YHaCtfn2UqKbhB3a@kroah.com> (raw)
In-Reply-To: <20210414043303.1072552-1-npache@redhat.com>
On Wed, Apr 14, 2021 at 12:33:02AM -0400, Nico Pache wrote:
> There are few instances of KUNIT tests that are not properly defined.
> This commit focuses on correcting these issues to match the standard
> defined in the Documentation.
>
> Issues Fixed:
> - Tests should default to KUNIT_ALL_TESTS
> - Tests configs tristate should have `if !KUNIT_ALL_TESTS`
> - Tests should end in KUNIT_TEST, some fixes have been applied to
> correct issues were KUNIT_TESTS is used or KUNIT is not mentioned.
>
> No functional changes other than CONFIG name changes
> Signed-off-by: Nico Pache <npache@redhat.com>
Please put a blank line before your signed-off-by, as is required by the
tools :(
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-14 5:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 4:33 [PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the standard Nico Pache
2021-04-14 5:50 ` Greg KH [this message]
2021-04-14 5:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHaCtfn2UqKbhB3a@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=brendanhiggins@google.com \
--cc=geert@linux-m68k.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=netdev@vger.kernel.org \
--cc=npache@redhat.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).