Linux-ext4 Archive on lore.kernel.org
 help / color / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Nico Pache <npache@redhat.com>
Cc: linux-kernel@vger.kernel.org, brendanhiggins@google.com,
	gregkh@linuxfoundation.org, linux-ext4@vger.kernel.org,
	netdev@vger.kernel.org, rafael@kernel.org,
	linux-m68k@vger.kernel.org, geert@linux-m68k.org,
	mathew.j.martineau@linux.intel.com, davem@davemloft.net,
	broonie@kernel.org, davidgow@google.com,
	skhan@linuxfoundation.org, mptcp@lists.linux.dev
Subject: Re: [PATCH v2 3/6] kunit: ext4: adhear to KUNIT formatting standard
Date: Sun, 18 Apr 2021 15:41:11 -0400
Message-ID: <YHyLV1SVfGVLRG2+@mit.edu> (raw)
In-Reply-To: <cbc925da29648e3c9fa6d0945331914911ab6d40.1618388989.git.npache@redhat.com>

On Wed, Apr 14, 2021 at 04:58:06AM -0400, Nico Pache wrote:
> Drop 'S' from end of CONFIG_EXT4_KUNIT_TESTS inorder to adhear to the KUNIT
> *_KUNIT_TEST config name format.

Another spelling nit, that should be "in order".

This will break people who have existing .kunitconfig files, but if we
are going to make this a standard (but please document it as a
standard first!), might as well do it sooner rather than later.

Cheers,

							- Ted

  reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-14  8:58 [PATCH v2 0/6] kunit: Fix formatting of KUNIT tests to meet the standard Nico Pache
2021-04-14  8:58 ` [PATCH v2 1/6] kunit: ASoC: topology: adhear to KUNIT formatting standard Nico Pache
2021-04-14 14:20   ` Mark Brown
2021-04-14  8:58 ` [PATCH v2 2/6] kunit: software node: " Nico Pache
2021-04-14  8:58 ` [PATCH v2 3/6] kunit: ext4: " Nico Pache
2021-04-18 19:41   ` Theodore Ts'o [this message]
2021-04-14  8:58 ` [PATCH v2 4/6] kunit: lib: " Nico Pache
2021-04-14  8:58 ` [PATCH v2 5/6] kunit: mptcp: " Nico Pache
2021-04-14  9:25   ` Matthieu Baerts
2021-04-15  6:01     ` David Gow
2021-04-15  7:10       ` Matthieu Baerts
2021-04-17  4:24         ` David Gow
2021-04-17  8:02           ` Matthieu Baerts
2021-04-19  7:40           ` Geert Uytterhoeven
2021-04-14  8:58 ` [PATCH v2 6/6] m68k: update configs to match the proper KUNIT syntax Nico Pache
2021-04-14 16:06 ` (subset) [PATCH v2 0/6] kunit: Fix formatting of KUNIT tests to meet the standard Mark Brown
2021-04-18 19:39 ` Theodore Ts'o
2021-04-22 20:39   ` Nico Pache
2021-04-23  6:26     ` David Gow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHyLV1SVfGVLRG2+@mit.edu \
    --to=tytso@mit.edu \
    --cc=brendanhiggins@google.com \
    --cc=broonie@kernel.org \
    --cc=davem@davemloft.net \
    --cc=davidgow@google.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=npache@redhat.com \
    --cc=rafael@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ext4 Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-ext4/0 linux-ext4/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-ext4 linux-ext4/ https://lore.kernel.org/linux-ext4 \
		linux-ext4@vger.kernel.org
	public-inbox-index linux-ext4

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ext4


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git