From: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
To: tytso@mit.edu
Cc: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>,
Jan Kara <jack@suse.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Updated locking documentation for transaction_t
Date: Thu, 20 Jun 2019 22:45:52 +0200 [thread overview]
Message-ID: <af5a4a51-c1e4-ab4a-14b4-5b0f120bd1be@tu-dortmund.de> (raw)
In-Reply-To: <20190408083500.66759-1-alexander.lochmann@tu-dortmund.de>
[-- Attachment #1.1: Type: text/plain, Size: 1807 bytes --]
Hi Ted,
Have you had the chance to review the most recent version of the patch?
Does it look reasonable to you?
Cheers,
Alex
On 08.04.19 10:35, Alexander Lochmann wrote:
> We used LockDoc to derive locking rules for each member
> of struct transaction_t.
> Based on those results, we extended the existing documentation
> by more members of struct transaction_t, and updated the existing
> documentation.
>
> Signed-off-by: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
> Signed-off-by: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>
> ---
> include/linux/jbd2.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 0f919d5fe84f..34b728e2b702 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -534,6 +534,7 @@ struct transaction_chp_stats_s {
> * The transaction keeps track of all of the buffers modified by a
> * running transaction, and all of the buffers committed but not yet
> * flushed to home for finished transactions.
> + * (Locking Documentation improved by LockDoc)
> */
>
> /*
> @@ -652,12 +653,12 @@ struct transaction_s
> unsigned long t_start;
>
> /*
> - * When commit was requested
> + * When commit was requested [journal_t.j_state_lock]
> */
> unsigned long t_requested;
>
> /*
> - * Checkpointing stats [j_checkpoint_sem]
> + * Checkpointing stats [journal_t.j_list_lock]
> */
> struct transaction_chp_stats_s t_chp_stats;
>
>
--
Technische Universität Dortmund
Alexander Lochmann PGP key: 0xBC3EF6FD
Otto-Hahn-Str. 16 phone: +49.231.7556141
D-44227 Dortmund fax: +49.231.7556116
http://ess.cs.tu-dortmund.de/Staff/al
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-06-20 21:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 8:35 [PATCH v3] Updated locking documentation for transaction_t Alexander Lochmann
2019-06-20 20:45 ` Alexander Lochmann [this message]
2020-10-15 13:26 ` Alexander Lochmann
2020-12-03 14:04 ` Theodore Y. Ts'o
2020-12-03 14:38 ` Alexander Lochmann
2020-12-03 20:39 ` Theodore Y. Ts'o
2020-10-15 13:56 ` [RFC] Fine-grained locking documentation for jbd2 data structures Alexander Lochmann
2021-02-05 15:31 ` Alexander Lochmann
2021-02-08 15:27 ` Jan Kara
2021-02-09 9:58 ` Alexander Lochmann
2021-02-09 12:00 ` Jan Kara
2021-02-09 13:47 ` Alexander Lochmann
2021-02-09 16:48 ` Jan Kara
2021-02-11 17:14 [PATCH v3] Updated locking documentation for transaction_t Alexander Lochmann
2021-03-17 20:58 ` Alexander Lochmann
2021-04-02 15:40 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af5a4a51-c1e4-ab4a-14b4-5b0f120bd1be@tu-dortmund.de \
--to=alexander.lochmann@tu-dortmund.de \
--cc=horst.schirmeier@tu-dortmund.de \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).