From: Jonny Grant <jg@jguk.org>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] /fs/ext4/ext4.h add a comment to ext4_dir_entry_2
Date: Sun, 17 May 2020 23:39:19 +0100 [thread overview]
Message-ID: <d7f22961-2fb2-d69a-28cc-073b735c6907@jguk.org> (raw)
In-Reply-To: <3DF89355-488D-47F5-857B-3B75D4E89AD3@dilger.ca>
On 11/05/2020 21:19, Andreas Dilger wrote:
> On May 8, 2020, at 2:36 PM, Jonny Grant <jg@jguk.org> wrote:
>>
>> Please find attached patch for review.
>>
>> 2020-05-08 Jonny Grant <jg@jguk.org>
>>
>> tests: comment ext4_dir_entry_2 file_type member
>>
>> Cheers, Jonny
>> <ext4_ext4_dir_entry_2.patch>
>
> Hi Jonny,
> thanks for your patch. The patch itself looks reasonable, but can
> you please submit it as inline text next time. To avoid issues with
> whitespace formatting, you can use "git send-email" directly from
> the command-line after making a commit with this change in it.
>
> Also, the subject line of the patch should just have "ext4:" as the
> subsystem, you don't need the whole pathname for the file, like:
>
> ext4: add comment for ext4_dir_entry_2 file_type member
>
> Finally, you should add a line:
>
> Signed-off-by: Jonny Grant <jg@jguk.org>
>
> to indicate that you wrote the patch and you are OK with others using it.
>
> See Documentation/process/submitting-patches.rst for full details.
>
> Cheers, Andreas
Many thanks for your reply Andreas. I will follow your that patch guide,
thank you for the link.
Could I check, did you submit, or shall I submit via git send-email ?
Many thanks
Jonny
next prev parent reply other threads:[~2020-05-17 22:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 20:36 [PATCH] /fs/ext4/ext4.h add a comment to ext4_dir_entry_2 Jonny Grant
2020-05-11 20:19 ` Andreas Dilger
2020-05-17 22:39 ` Jonny Grant [this message]
2020-05-18 4:01 ` Andreas Dilger
2020-05-21 17:20 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7f22961-2fb2-d69a-28cc-073b735c6907@jguk.org \
--to=jg@jguk.org \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).