From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1601AC433ED for ; Thu, 22 Apr 2021 20:39:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DEE24613CD for ; Thu, 22 Apr 2021 20:39:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236974AbhDVUjt (ORCPT ); Thu, 22 Apr 2021 16:39:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:26768 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236877AbhDVUjr (ORCPT ); Thu, 22 Apr 2021 16:39:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619123952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cNpLvi6EdAaudYQUjNEEJ6bmi8/lRMsChihQZX3u/nI=; b=THey2O8FKxkdsYJm8XVkVJ/okMJNlEuCeBq7dYJzFlfB3CtQEKnKV+BCj5agkN/vryKJ9x Yo/e+gGzCw0kX3X8k8hTyrpxcSv50OCPO0RSjF1V9MpruX/5eA/0HZU17ZhqFp2yY8HgU1 zwJPHE2zPr9WChN1VT2s5371d/pf8E8= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-449-6Ff-P7yyORaooL9mhl6EvA-1; Thu, 22 Apr 2021 16:39:10 -0400 X-MC-Unique: 6Ff-P7yyORaooL9mhl6EvA-1 Received: by mail-qk1-f197.google.com with SMTP id t126-20020a37aa840000b02902e3c5b3abeaso10022453qke.10 for ; Thu, 22 Apr 2021 13:39:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=cNpLvi6EdAaudYQUjNEEJ6bmi8/lRMsChihQZX3u/nI=; b=kOaNYJr4Di5fUkMS342KKSgfWxo0ucdx6QHsY9mW9FrpxZ0STET24xKEY1axAFv9YU fyYDQi7HcEqEM+HfSUrP7j4I9tYOvQbMXnVVA2st8R9GcZXgyBRr8PPjIe0o3X8C8vWr HubzlccOAjlSgcOhkjdM5MnE35bFfQjdcmxZ9OIK95eXOxQzsmvt8gh6Nk82uSQDWM9G 3DwWcOmoZ05HdEsy/I6W6hg2vf4bRl/SbbeBFZm6xA5nU9YK2Se+FwE888h5KUvSUw4H ru0wPf3vDj/lJlgJZZlEeMsALdN4pfnE4cNVVzLCoC6P6LtCjcOAvqjWWEtWrVfnxhJc /lUA== X-Gm-Message-State: AOAM531QPYweBItcc9hm5i+3zasP1LDR39xWMDboj+nlsrnVpUwnKNkq sXklwAHFV2RcSUtESXXeo8dmp0/honuOOQkEZTLgdso9p7aZOF/drsUXkminJ88UOcMACD4l1T8 7J0cwngGWUZ+/684A3Xnt3A== X-Received: by 2002:a0c:e14e:: with SMTP id c14mr617265qvl.36.1619123949708; Thu, 22 Apr 2021 13:39:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcGeYSvpo24gXWSguEVi9JQ7kiE7Jqh/3hwJUN+VQ7PimQTarKqFfkP4TIFwc1yNxophk9lw== X-Received: by 2002:a0c:e14e:: with SMTP id c14mr617245qvl.36.1619123949525; Thu, 22 Apr 2021 13:39:09 -0700 (PDT) Received: from localhost.localdomain ([2601:184:417f:70c0::42e6]) by smtp.gmail.com with ESMTPSA id x20sm2989311qkf.42.2021.04.22.13.39.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Apr 2021 13:39:09 -0700 (PDT) Subject: Re: [PATCH v2 0/6] kunit: Fix formatting of KUNIT tests to meet the standard To: Theodore Ts'o , brendanhiggins@google.com, davidgow@google.com Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, linux-ext4@vger.kernel.org, netdev@vger.kernel.org, rafael@kernel.org, linux-m68k@vger.kernel.org, geert@linux-m68k.org, mathew.j.martineau@linux.intel.com, davem@davemloft.net, broonie@kernel.org, skhan@linuxfoundation.org, mptcp@lists.linux.dev References: From: Nico Pache Message-ID: Date: Thu, 22 Apr 2021 16:39:07 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 4/18/21 3:39 PM, Theodore Ts'o wrote: > On Wed, Apr 14, 2021 at 04:58:03AM -0400, Nico Pache wrote: >> There are few instances of KUNIT tests that are not properly defined. >> This commit focuses on correcting these issues to match the standard >> defined in the Documentation. > The word "standard" seems to be over-stating things. The > documentation currently states, "they _usually_ have config options > ending in ``_KUNIT_TEST'' (emphasis mine). I can imagine that there > might be some useful things we can do from a tooling perspective if we > do standardize things, but if you really want to make it a "standard", > we should first update the manpage to say so, KUNIT Maintainers, should we go ahead and make this the "standard"? As Ted has stated...  consistency with 'grep' is my desired outcome. > and explain why (e.g., > so that we can easily extract out all of the kunit test modules, and > perhaps paint a vision of what tools might be able to do with such a > standard). > > Alternatively, the word "standard" could perhaps be changed to > "convention", which I think more accurately defines how things work at > the moment.Nico Pache (6): > kunit: ASoC: topology: adhear to KUNIT formatting standard > kunit: software node: adhear to KUNIT formatting standard > kunit: ext4: adhear to KUNIT formatting standard > kunit: lib: adhear to KUNIT formatting standard > kunit: mptcp: adhear to KUNIT formatting standard > m68k: update configs to match the proper KUNIT syntax > > Also, "adhear" is not the correct spelling; the correct spelling is > "adhere" (from the Latin verb "adhaerere", "to stick", as in "to hold > fast or stick by as if by gluing", which then became "to bind oneself > to the observance of a set of rules or standards or practices"). > > - Ted Whoops... Made that mistake in my v1 and inadvertently copied it over to all the patches. Cheers! -- Nico