From: Zac via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: "'Chao Yu'" <yuchao0@huawei.com>, <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] 回复: [PATCH] f2fs-tools: set cold flag for non-dir node
Date: Fri, 19 Jun 2020 10:21:07 +0800 [thread overview]
Message-ID: <000001d645e0$4aa645d0$dff2d170$@wingtech.com> (raw)
In-Reply-To: <4a2d19c4-1ede-0172-fe50-c8464ee341df@huawei.com>
> On 2020/6/18 20:48, zhaowuyun@wingtech.com wrote:
> > From: Wuyun Zhao <zhaowuyun@wingtech.com>
>
> Thanks for the patch. :)
>
> Please add commit message here.
OK
> >
> > Signed-off-by: Wuyun Zhao <zhaowuyun@wingtech.com>
> > ---
> > fsck/dir.c | 1 +
> > fsck/node.c | 1 +
> > fsck/node.h | 11 +++++++++++
> > 3 files changed, 13 insertions(+)
> >
> > diff --git a/fsck/dir.c b/fsck/dir.c
> > index 5f4f75e..dc03c98 100644
> > --- a/fsck/dir.c
> > +++ b/fsck/dir.c
> > @@ -522,6 +522,7 @@ static void init_inode_block(struct f2fs_sb_info
> *sbi,
> > node_blk->footer.nid = cpu_to_le32(de->ino);
> > node_blk->footer.flag = 0;
> > node_blk->footer.cp_ver = ckpt->checkpoint_ver;
> > + set_cold_node(node_blk, S_ISDIR(mode));
> >
> > if (S_ISDIR(mode)) {
> > make_empty_dir(sbi, node_blk);
> > diff --git a/fsck/node.c b/fsck/node.c
> > index 229a99c..1d291ca 100644
> > --- a/fsck/node.c
> > +++ b/fsck/node.c
> > @@ -79,6 +79,7 @@ block_t new_node_block(struct f2fs_sb_info *sbi,
> > node_blk->footer.ino = f2fs_inode->footer.ino;
> > node_blk->footer.flag = cpu_to_le32(ofs << OFFSET_BIT_SHIFT);
> > node_blk->footer.cp_ver = ckpt->checkpoint_ver;
> > + set_cold_node(node_blk, S_ISDIR(le16_to_cpu(f2fs_inode->i.i_mode)));
>
> How about wrapping these node footer fields assignment into a function?
> then
> we can reuse this in other places.
>
> void set_node_footer(nid, ino, ofs, ver, is_dir)
> {
> node_blk->footer.nid = cpu_to_le32(nid);
> node_blk->footer.ino = f2fs_inode->footer.ino;
> node_blk->footer.flag = cpu_to_le32(ofs << OFFSET_BIT_SHIFT);
> node_blk->footer.cp_ver = ckpt->checkpoint_ver;
> set_cold_node(node_blk, S_ISDIR(le16_to_cpu(f2fs_inode->i.i_mode)));
> }
Ok, That's good.
> >
> > type = CURSEG_COLD_NODE;
> > if (IS_DNODE(node_blk)) {
> > diff --git a/fsck/node.h b/fsck/node.h
> > index 6bce1fb..99139b1 100644
> > --- a/fsck/node.h
> > +++ b/fsck/node.h
> > @@ -161,6 +161,17 @@ static inline int is_node(struct f2fs_node
> *node_blk, int type)
> > return le32_to_cpu(node_blk->footer.flag) & (1 << type);
> > }
>
> Beside this, I think we need to use set_node_footer() in:
> - f2fs_write_root_inode
> - f2fs_write_qf_inode
> - f2fs_write_lpf_inode
>
> as well to fix mkfs bugs.
the root inode and the lpf inode is dir, need to set cold flag?
> Thanks,
>
> >
> > +static inline void set_cold_node(struct f2fs_node *rn, bool is_dir)
> > +{
> > + unsigned int flag = le32_to_cpu(rn->footer.flag);
> > +
> > + if (is_dir)
> > + flag &= ~(0x1 << COLD_BIT_SHIFT);
> > + else
> > + flag |= (0x1 << COLD_BIT_SHIFT);
> > + rn->footer.flag = cpu_to_le32(flag);
> > +}
> > +
> > #define is_fsync_dnode(node_blk) is_node(node_blk, FSYNC_BIT_SHIFT)
> > #define is_dent_dnode(node_blk) is_node(node_blk,
> DENT_BIT_SHIFT)
> >
> >
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-06-19 2:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 12:48 [f2fs-dev] [PATCH] f2fs-tools: set cold flag for non-dir node zhaowuyun--- via Linux-f2fs-devel
2020-06-19 1:31 ` Chao Yu
2020-06-19 2:21 ` Zac via Linux-f2fs-devel [this message]
2020-06-19 2:48 ` [f2fs-dev] 回复: " Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d645e0$4aa645d0$dff2d170$@wingtech.com' \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
--cc=zhaowuyun@wingtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).