From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=CHARSET_FARAWAY_HEADER, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9360FC433E0 for ; Thu, 18 Jun 2020 11:01:24 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CA9C20885; Thu, 18 Jun 2020 11:01:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lists.sourceforge.net header.i=@lists.sourceforge.net header.b="CWC7lAN6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="IRYx/sAp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="miBh8Cbd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CA9C20885 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=lists.sourceforge.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:MIME-Version:Message-ID:Date:In-Reply-To: References:To:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WkraQaHx2u0yl+rzz+eurIJn6IsfibPwNZ36+lRsggg=; b=CWC7lAN6JGjhqu+iyGv6pBdXfv lrpK8fACO0Rk2nVaGhPSSjj0+kNfyw9vVkhAxjRJqSBP9UDdSNouFk2P93RODFtNAdVVk+ZO3MPWF JZg5z1UjGYXnhWz4ELHqTATDz233oGEHs37j79dA6O9xDdZBPARFoclKksxTZK9168sM=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jlsIL-00046I-8f; Thu, 18 Jun 2020 11:01:21 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlsIJ-00045o-IF for linux-f2fs-devel@lists.sourceforge.net; Thu, 18 Jun 2020 11:01:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-ID:Date:Subject:In-Reply-To:References:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=waVuI+fhDL3OO1BIlX634G7i/WNiUY8x41/avPLA/38=; b=IRYx/sApbJa7YXrAgnCOKwaqxH y7PzMcSsZKZ4/nN/ABTiGbcfV9dZ7zulM949ZKExvmiQ9F5ZtF+Aummrxc4bA523eJyuOMQAVJ5/O /6SzLQUExMiN0dOi+p0TcRPn473lfsLeKEFLJm97GsW2XX+WJDW9nrknxep8x4xKyHw4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date: Subject:In-Reply-To:References:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=waVuI+fhDL3OO1BIlX634G7i/WNiUY8x41/avPLA/38=; b=miBh8Cbd3cqYSUNB8/FcnlD4py 9HA+T7SVe9hkWaFhp948CnGhBkMtg9f/etN6nae+XvKzrjmk4u9yDKde/gHzYr9sJzLGMA5JTgdKm +c83AWaFjXGI3OOcQ5/7WQbB7hIylkPOL6eYCRUGAJjo2iJxG9zCNRmTIWaSxIfgJBiM=; Received: from mx.wingtech.com ([180.166.216.14] helo=mail.wingtech.com) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA:256) (Exim 4.92.2) id 1jlsI7-007YR0-If for linux-f2fs-devel@lists.sourceforge.net; Thu, 18 Jun 2020 11:01:19 +0000 Received: from mx.wingtech.com ([192.168.2.43]) by mail.wingtech.com with SMTP id 05IB0q8X006494-05IB0q8Y006494 for ; Thu, 18 Jun 2020 19:00:52 +0800 Received: from 192.168.51.143 (HELO ZHAOWUYUN); Thu, 18 Jun 2020 19:00:50 +0800 To: "'Chao Yu'" , References: <1592384659-20203-1-git-send-email-zhaowuyun@wingtech.com> <86069ba3-cba3-7bc9-c90b-e931abd0dde5@huawei.com> <000001d64519$b05a1180$110e3480$@wingtech.com> <86c34c66-b370-6c6d-91fe-b9235f9c5785@huawei.com> <002d01d64520$840b4750$8c21d5f0$@wingtech.com> <48ede812-ef8b-aa41-e056-3b8fed064dad@huawei.com> In-Reply-To: <48ede812-ef8b-aa41-e056-3b8fed064dad@huawei.com> Date: Thu, 18 Jun 2020 19:00:52 +0800 Message-ID: <009501d6455f$bbb29160$3317b420$@wingtech.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJusS8b7G89rONhvQTSKQ9/POQtRgGSiybFAmikCJoCPxgJ/AION8odA0hqpnWnUNUUoA== Content-Language: zh-cn X-Headers-End: 1jlsI7-007YR0-If Subject: [f2fs-dev] =?gb2312?b?u9i4tDogu9i4tDogu9i4tDogW1BBVENIXSBmMmZz?= =?gb2312?b?OiBmaXggYSByYWNlIGNvbmRpdGlvbiBiZXR3ZWVuIGYyZnNfd3Jp?= =?gb2312?b?dGVfZW5kX2lvIGFuZCBmMmZzX2RlbF9mc3luY19ub2RlX2VudHJ5?= X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zac via Linux-f2fs-devel Reply-To: Zac Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net > On 2020/6/18 11:28, Zac wrote: > >> On 2020/6/18 10:39, Zac wrote: > >>> > >>>> On 2020/6/17 17:04, zhaowuyun@wingtech.com wrote: > >>>>> From: Wuyun Zhao > >>>>> > >>>>> Under some condition, the __write_node_page will submit a page > which > >> is > >>>> not > >>>>> f2fs_in_warm_node_list and will not call f2fs_add_fsync_node_entry. > >>>>> f2fs_gc continue to run to invoke f2fs_iget -> do_read_inode to read > > the > >>>> same node page > >>>>> and set code node, which make f2fs_in_warm_node_list become > true, > >>>>> that will cause f2fs_bug_on in f2fs_del_fsync_node_entry when > >>>> f2fs_write_end_io called. > >>>> Could you please add below race condition description into commit > >>>> message? > >>>> > >>>> - f2fs_write_end_io > >>>> - f2fs_iget > >>>> - do_read_inode > >>>> - set_cold_node > >>>> recover cold node flag > >>>> - f2fs_in_warm_node_list > >>>> - is_cold_node > >>>> if node is cold, assume we have added > >>>> node to fsync_node_list during writepages() > >>>> - f2fs_del_fsync_node_entry > >>>> - f2fs_bug_on() due to node page > >>>> is not in fsync_node_list > >>> > >>> Ok, will add the commit message. > >>> > >>>> BTW, I'm curious about why we can lose cold flag for non-dir inode? > >>>> any clue to reproduce this bug (I mean losing cold flag)? > >>> > >>> it's a f2fs image with 25600MB > >>> flash this image to device > >>> the device will resize it according to the userdata partition size which > > is > >>> about 94GB > >>> the device mount the f2fs partition > >>> then hit this f2fs_bug_on > >>> > >>> seems that the cold flag is not been set when mkfs > >> > >> Ah, I guess both mkfs/sload ignores setting cold node flag for non-dir > > inode, > >> could you please send another patch to fix this issue? > > > > Patch v2 has been sent. > > I see, it looks good to me. > > Actually, I meant we need to fix mkfs/sload bugs as well, do you have time > to > work on it? :) > > Thanks, Ok, I will try to work on it. > > > >>> > >>> I think the issue is that > >>> > >>> 1. the node page in the storage is without cold bit > >>> 2. f2fs_disable_checkpoint -> f2fs_gc -> f2fs_get_node_page, this page > >> won't > >>> be set cold flag > >>> 3. f2fs_move_node_page -> __write_node_page to write this page > >>> 4. f2fs_gc -> f2fs_iget -> do_read_inode to read this page and set cold > > flag > >> > >> Clear enough, thanks for your explanation. :) > >> > >> Thanks, > >> > >>> > >>>>> > >>>>> [ 34.966133] Call trace: > >>>>> [ 34.969902] f2fs_del_fsync_node_entry+0x100/0x108 > >>>>> [ 34.976071] f2fs_write_end_io+0x1e0/0x288 > >>>>> [ 34.981539] bio_endio+0x248/0x270 > >>>>> [ 34.986289] blk_update_request+0x2b0/0x4d8 > >>>>> [ 34.991841] scsi_end_request+0x40/0x440 > >>>>> [ 34.997126] scsi_io_completion+0xa4/0x748 > >>>>> [ 35.002593] scsi_finish_command+0xdc/0x110 > >>>>> [ 35.008143] scsi_softirq_done+0x118/0x150 > >>>>> [ 35.013610] blk_done_softirq+0x8c/0xe8 > >>>>> [ 35.018811] __do_softirq+0x2e8/0x578 > >>>>> [ 35.023828] irq_exit+0xfc/0x120 > >>>>> [ 35.028398] handle_IPI+0x1d8/0x330 > >>>>> [ 35.033233] gic_handle_irq+0x110/0x1d4 > >>>>> [ 35.038433] el1_irq+0xb4/0x130 > >>>>> [ 35.042917] kmem_cache_alloc+0x3f0/0x418 > >>>>> [ 35.048288] radix_tree_node_alloc+0x50/0xf8 > >>>>> [ 35.053933] __radix_tree_create+0xf8/0x188 > >>>>> [ 35.059484] __radix_tree_insert+0x3c/0x128 > >>>>> [ 35.065035] add_gc_inode+0x90/0x118 > >>>>> [ 35.069967] f2fs_gc+0x1b80/0x2d70 > >>>>> [ 35.074718] f2fs_disable_checkpoint+0x94/0x1d0 > >>>>> [ 35.080621] f2fs_fill_super+0x10c4/0x1b88 > >>>>> [ 35.086088] mount_bdev+0x194/0x1e0 > >>>>> [ 35.090923] f2fs_mount+0x40/0x50 > >>>>> [ 35.095589] mount_fs+0xb4/0x190 > >>>>> [ 35.100159] vfs_kern_mount+0x80/0x1d8 > >>>>> [ 35.105260] do_mount+0x478/0xf18 > >>>>> [ 35.109926] ksys_mount+0x90/0xd0 > >>>>> [ 35.114592] __arm64_sys_mount+0x24/0x38 > >>>>> > >>>>> Signed-off-by: Wuyun Zhao > >>>> > >>>> Reviewed-by: Chao Yu > >>>> > >>>> Thanks, > >>>> > >>>>> --- > >>>>> fs/f2fs/inode.c | 1 + > >>>>> 1 file changed, 1 insertion(+) > >>>>> > >>>>> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > >>>>> index be6ac33..0df5c8c 100644 > >>>>> --- a/fs/f2fs/inode.c > >>>>> +++ b/fs/f2fs/inode.c > >>>>> @@ -402,6 +402,7 @@ static int do_read_inode(struct inode *inode) > >>>>> > >>>>> /* try to recover cold bit for non-dir inode */ > >>>>> if (!S_ISDIR(inode->i_mode) && !is_cold_node(node_page)) { > >>>>> + f2fs_wait_on_page_writeback(node_page, NODE, true, true); > >>>>> set_cold_node(node_page, false); > >>>>> set_page_dirty(node_page); > >>>>> } > >>>>> > >>> > >>> . > >>> > > > > . > > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel