From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE191C43331 for ; Sat, 7 Sep 2019 01:23:28 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D4402082C; Sat, 7 Sep 2019 01:23:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="bIG+QCee"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="V05t54CO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="d6Gi2iA2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D4402082C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1i6PRn-00074I-1b; Sat, 07 Sep 2019 01:23:27 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1i6PRl-00074A-Ob for linux-f2fs-devel@lists.sourceforge.net; Sat, 07 Sep 2019 01:23:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uBw4XvrIKBZGlKOP1rj2pO3VsIqQY89xbmKxouNh4Hc=; b=bIG+QCeeq/bIhgPAHmmUVurt8H xcYRhyNyw41bjKCCB2/1JOYcyv92uHNSEs81MVwQUx+sG/mc1lIGjdtXm0aL4CSUHm4uKT7GAz7tG qoi9r6lCtUFtgSuDULnADxl8SbKrglUVf0efvtS4s8M202jORGkATw8kAMObIiFDCil0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uBw4XvrIKBZGlKOP1rj2pO3VsIqQY89xbmKxouNh4Hc=; b=V05t54COBb67rWaWR6F7dRaOJp uSQQp4HKlEnCH8FSnN1yi8rmteJBPHy+S6GyNA9WzCM+qicFfDL9hr/ISFN+p5ysrmtqxhejAQSus ehV2ZfMs+niteHZBQtvKnHdj7orENr+Fq/hbY1Di0iVvpFHxwKYlvWeoyOo2NPrkFLTU=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1i6PRh-00CcB6-I9 for linux-f2fs-devel@lists.sourceforge.net; Sat, 07 Sep 2019 01:23:25 +0000 Received: from [192.168.0.103] (unknown [58.212.132.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC1A52082C; Sat, 7 Sep 2019 01:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567819395; bh=G2qrEEZDP+ylIjE+oHbp2sIifoKcC+Sj0d+XOwYiqKg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=d6Gi2iA2x7J2Xs5Qvy6fyPxLqpV0zG5uknZNOqx3ssG/vbfn8yYmzRKPKAcZC2F8p eFwYwhfpIGHdk2bTKSVnsEiEFwDeFHvBRuaailkso8jduBq2L0OrHQUAx3sTXz4SlE 8vKf9lI1XrWiG8+ZEouRbqaYyTE0g48NHadZunXk= To: Jaegeuk Kim , Chao Yu References: <20190906105426.109151-1-yuchao0@huawei.com> <20190906234808.GC71848@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: <080e8dee-4726-8294-622a-cac26e781083@kernel.org> Date: Sat, 7 Sep 2019 09:23:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190906234808.GC71848@jaegeuk-macbookpro.roam.corp.google.com> Content-Language: en-US X-Headers-End: 1i6PRh-00CcB6-I9 Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to avoid accessing uninitialized field of inode page in is_alive() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2019-9-7 7:48, Jaegeuk Kim wrote: > On 09/06, Chao Yu wrote: >> If inode is newly created, inode page may not synchronize with inode cache, >> so fields like .i_inline or .i_extra_isize could be wrong, in below call >> path, we may access such wrong fields, result in failing to migrate valid >> target block. > > If data is valid, how can we get new inode page? is_alive() { ... node_page = f2fs_get_node_page(sbi, nid); <--- inode page source_blkaddr = datablock_addr(NULL, node_page, ofs_in_node); ... } datablock_addr() { ... base = offset_in_addr(&raw_node->i); <--- the base could be wrong here due to accessing uninitialized .i_inline of raw_node->i. ... } Thanks, > >> >> - gc_data_segment >> - is_alive >> - datablock_addr >> - offset_in_addr >> >> Fixes: 7a2af766af15 ("f2fs: enhance on-disk inode structure scalability") >> Signed-off-by: Chao Yu >> --- >> fs/f2fs/dir.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c >> index 765f13354d3f..b1840852967e 100644 >> --- a/fs/f2fs/dir.c >> +++ b/fs/f2fs/dir.c >> @@ -479,6 +479,9 @@ struct page *f2fs_init_inode_metadata(struct inode *inode, struct inode *dir, >> if (IS_ERR(page)) >> return page; >> >> + /* synchronize inode page's data from inode cache */ >> + f2fs_update_inode(inode, page); >> + >> if (S_ISDIR(inode->i_mode)) { >> /* in order to handle error case */ >> get_page(page); >> -- >> 2.18.0.rc1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel