From: Chao Yu <yuchao0@huawei.com>
To: Pavel Machek <pavel@ucw.cz>, <jaegeuk@kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>,
kernel list <linux-kernel@vger.kernel.org>,
<sfr@canb.auug.org.au>, <david@ixit.cz>
Subject: Re: [f2fs-dev] f2fs compile problem in next-20191220 on x86-32
Date: Thu, 26 Dec 2019 09:32:09 +0800 [thread overview]
Message-ID: <0d067e7a-e301-0c1a-c651-33845ad2c333@huawei.com> (raw)
In-Reply-To: <20191225130456.GA18929@duo.ucw.cz>
On 2019/12/25 21:04, Pavel Machek wrote:
> On Sun 2019-12-22 16:49:17, Pavel Machek wrote:
>> Hi!
>>
>> I'm getting this:
>>
>> LD .tmp_vmlinux1
>> ld: fs/f2fs/file.o: in function `f2fs_truncate_blocks':
>> file.c:(.text+0x2968): undefined reference to `__udivdi3'
>> make: *** [Makefile:1079: vmlinux] Error 1
>>
>> when attempting to compile kernel for x86-32.
>
> David bisected it:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=205967
>
> And the bug is actually easy to see:
>
> +int f2fs_truncate_blocks(struct inode *inode, u64 from, bool lock)
> +{
> + u64 free_from = from;
> +
> + /*
> + * for compressed file, only support cluster size
> + * aligned truncation.
> + */
> + if (f2fs_compressed_file(inode)) {
> + size_t cluster_size = PAGE_SIZE <<
> + F2FS_I(inode)->i_log_cluster_size;
> +
> + free_from = roundup(from, cluster_size);
>
> #define roundup(x, y) ( \
> { \
> typeof(y) __y = y; \
> (((x) + (__y - 1)) / __y) * __y; \
> } \
>
> div64 is needed instead of div in the roundup macro. Or actually... It
> is quite stupid to use roundup like this on value that is power of
> two, right?
This has been fixed in dev branch, could you check that? People still saw this
issue because linux-next did not update after we fix this bug.
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev
Thanks,
>
> Best regards,
> Pavel
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
parent reply other threads:[~2019-12-26 1:32 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20191225130456.GA18929@duo.ucw.cz>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d067e7a-e301-0c1a-c651-33845ad2c333@huawei.com \
--to=yuchao0@huawei.com \
--cc=david@ixit.cz \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).