From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7983DC3404C for ; Wed, 19 Feb 2020 03:01:38 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 435C222B48; Wed, 19 Feb 2020 03:01:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="SSBkqUt1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="KwaG7VJt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 435C222B48 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1j4FcG-0004CB-26; Wed, 19 Feb 2020 03:01:36 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j4FcD-0004Bm-NK for linux-f2fs-devel@lists.sourceforge.net; Wed, 19 Feb 2020 03:01:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UbmaCLmh0i4I8qrL/Ntqj/wUGdQh1dlDPOrhbY9RF7E=; b=SSBkqUt17gOuuPNNMbCJwsRl15 O1CZvPAJ8Ajjtzvb/w4NxLkTAHSx/2SZEMrCEjYDcMpqCDV76ftiVyFkxJjiLqoaYL57OQbfbd9Vl 8WKCjdzv8nzqgOurK/LuN3e2CD0UIE18YQKV9Ig9duiITRR5RgLOVUTbdpdWZl5IEM6w=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UbmaCLmh0i4I8qrL/Ntqj/wUGdQh1dlDPOrhbY9RF7E=; b=KwaG7VJtBNAq3Ni4wBOABPCBtR R/T/EZEbn2t5Bh48coaXexoetAaf2njhLl9dhnPU1Eyo5qazxQAQq6Y1c8Se2PEk9R0iFVjkvqak/ eWvuwpn8lop3uyb9IZpDReGMp/3rJgrMaAVr6zTSO8X/g1PcqdwDsd1RuGj80TGhgfpY=; Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1j4FcB-00H9Z9-W9 for linux-f2fs-devel@lists.sourceforge.net; Wed, 19 Feb 2020 03:01:33 +0000 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 580147073D7EF8328B36; Wed, 19 Feb 2020 11:01:23 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.213) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 19 Feb 2020 11:01:21 +0800 To: Jaegeuk Kim References: <20200214185855.217360-1-jaegeuk@kernel.org> <20200214185855.217360-3-jaegeuk@kernel.org> <9c497f3e-3399-e4a6-f81c-6c4a1f35e5bb@huawei.com> <20200218232714.GB10213@google.com> From: Chao Yu Message-ID: <117a927f-7128-b5a1-a961-22934bb62ec5@huawei.com> Date: Wed, 19 Feb 2020 11:01:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200218232714.GB10213@google.com> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1j4FcB-00H9Z9-W9 Subject: Re: [f2fs-dev] [PATCH 3/3] f2fs: skip migration only when BG_GC is called X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020/2/19 7:27, Jaegeuk Kim wrote: > On 02/17, Chao Yu wrote: >> On 2020/2/15 2:58, Jaegeuk Kim wrote: >>> FG_GC needs to move entire section more quickly. >>> >>> Signed-off-by: Jaegeuk Kim >>> --- >>> fs/f2fs/gc.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c >>> index bbf4db3f6bb4..1676eebc8c8b 100644 >>> --- a/fs/f2fs/gc.c >>> +++ b/fs/f2fs/gc.c >>> @@ -1203,7 +1203,7 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi, >>> >>> if (get_valid_blocks(sbi, segno, false) == 0) >>> goto freed; >>> - if (__is_large_section(sbi) && >>> + if (gc_type == BG_GC && __is_large_section(sbi) && >>> migrated >= sbi->migration_granularity) >> >> I knew migrating one large section is a more efficient way, but this can >> increase long-tail latency of f2fs_balance_fs() occasionally, especially in >> extreme fragmented space. > > FG_GC requires to wait for whole section migration which shows the entire > latency. That will cause long-tail latency for single f2fs_balance_fs() procedure, which it looks a very long hang when userspace call f2fs syscall, so why not splitting total elapsed time into several f2fs_balance_fs() to avoid that. Thanks, > >> >> Thanks, >> >>> goto skip; >>> if (!PageUptodate(sum_page) || unlikely(f2fs_cp_error(sbi))) >>> > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel