From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (unknown [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 782BEC6FD1C for ; Thu, 23 Mar 2023 14:22:58 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pfLqB-0008JF-7I; Thu, 23 Mar 2023 14:22:55 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pfLqA-0008J9-JA for linux-f2fs-devel@lists.sourceforge.net; Thu, 23 Mar 2023 14:22:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xBRxRdtbJAUT2jV+zTD/msAyMpz6AutpBXp0TseqPIU=; b=S1lVtOONxjKK9W/Vkl0CYRwjjk wQx/VV57jXGxwWCLcpaIUsNA3+LKiXu4Hg20qWUzCr51lAJX+N6+CMjldFZKms75aU8xcbU2pxxYB 8iOpTXbPb7EL0mFBCdQNEh/BnxeMX79eoXfroxvWAMlj5TKTccKbSCw1RDaKHTsziLhQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xBRxRdtbJAUT2jV+zTD/msAyMpz6AutpBXp0TseqPIU=; b=AunTVA21FNwRsR5tso4Wt/qxxA 9UyhfOc1hpkWMvM3ba0QLOEL0I23YdV0ecSd10FkaTXlhUuc6PSjGJNaDOJquGxoAJqkOPEAud82c l1xARA2J/4eN29/KBVS1ls47mOnn2g3hPFFRRbQ8JmI3sileVSY1MeEUgNgo9Cezxyi8=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1pfLqA-0004GE-Hn for linux-f2fs-devel@lists.sourceforge.net; Thu, 23 Mar 2023 14:22:55 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DD242B82150 for ; Thu, 23 Mar 2023 14:22:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 234A6C433EF; Thu, 23 Mar 2023 14:22:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679581362; bh=oLBZ5saccObS7spgsMIqKWYoT4RvPNG3T4ino9R/8ZY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nuLlZifEIypUrr/JFr527EJNPaJFb4L0y4JjGyYA02xIuA4BlL9kGmqwZT8O7t0+8 Wz0g7aXR4rq2VsWkf3h1Z+jv3nh6stkcw3/DBBj9AQIN75gA8YZ6+t88eHUjASaCEt cXvy9zakN1/wo3a4lkko+Ia/X+DhQHu1EDkzfJVj6SDViL3dXqHeoOKxm+xcxDUGi/ Q4ypRMQo0WzIbPhCsnmZDgkYNHhEo2vBXc/yVsjoiLolv2O1SzcrJcrtDKV/7/kTBo 0jrdVKdCRkswTxu1/EmobAiNJbNEgtFWhqMjmkAm7JIaKJqawowu04jR94WWKMgPqZ S/3sIdyAol7CQ== Message-ID: <12dfeede-70e3-5c1b-7d3d-9f21c8ee9ff7@kernel.org> Date: Thu, 23 Mar 2023 22:22:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20230313201216.924234-1-jaegeuk@kernel.org> <20230313201216.924234-2-jaegeuk@kernel.org> From: Chao Yu In-Reply-To: <20230313201216.924234-2-jaegeuk@kernel.org> X-Headers-End: 1pfLqA-0004GE-Hn Subject: Re: [f2fs-dev] [PATCH 1/3] f2fs: factor out victim_entry usage from general rb_tree use X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2023/3/14 4:12, Jaegeuk Kim wrote: > Let's reduce the complexity of mixed use of rb_tree in victim_entry from > extent_cache and discard_cmd. > > This should fix arm32 memory alignment issue caused by shared rb_entry. > > [struct victim_entry] [struct rb_entry] > [0] struct rb_node rb_node; [0] struct rb_node rb_node; > union { > struct { > unsigned int ofs; > unsigned int len; > }; > [16] unsigned long long mtime; [12] unsigned long long key; > } __packed; > > Cc: > Fixes: 093749e296e2 ("f2fs: support age threshold based garbage collection") > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel