From: Xiaojun Wang <wangxiaojun11@huawei.com>
To: <linux-fsdevel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>
Subject: [f2fs-dev] [PATCH] f2fs: fix memory leak in build_directory
Date: Wed, 31 Jul 2019 11:27:01 +0800 [thread overview]
Message-ID: <1564543621-123550-1-git-send-email-wangxiaojun11@huawei.com> (raw)
This patch fix bug that variable dentries going
out of scope leaks the storage it points to.
Signed-off-by: Xiaojun Wang<wangxiaojun11@huawei.com>
---
fsck/sload.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/fsck/sload.c b/fsck/sload.c
index f5a4651..e5de2e1 100644
--- a/fsck/sload.c
+++ b/fsck/sload.c
@@ -240,15 +240,18 @@ static int build_directory(struct f2fs_sb_info *sbi, const char *full_path,
ret = set_selinux_xattr(sbi, dentries[i].path,
dentries[i].ino, dentries[i].mode);
if (ret)
- return ret;
+ goto out;
+ }
+out:
+ for (i = 0; i < entries; i++) {
free(dentries[i].path);
free(dentries[i].full_path);
free((void *)dentries[i].name);
}
free(dentries);
- return 0;
+ return ret;
}
static int configure_files(void)
--
2.7.4
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next reply other threads:[~2019-07-31 3:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 3:27 Xiaojun Wang [this message]
2019-07-31 10:24 ` [f2fs-dev] [PATCH] f2fs: fix memory leak in build_directory Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1564543621-123550-1-git-send-email-wangxiaojun11@huawei.com \
--to=wangxiaojun11@huawei.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).