From: Ma Feng <mafeng.ma@huawei.com>
To: <chao@kernel.org>, <jaegeuk@kernel.org>
Cc: Ma Feng <mafeng.ma@huawei.com>, linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH] f2fs: compress: make num_compress_pages and f2fs_compress_free_page static
Date: Mon, 11 May 2020 19:51:26 +0800 [thread overview]
Message-ID: <1589197886-10580-1-git-send-email-mafeng.ma@huawei.com> (raw)
Fix the following sparse warning:
fs/f2fs/compress.c:501:5: warning: symbol 'num_compress_pages' was not declared.
Should it be static?
fs/f2fs/compress.c:530:6: warning: symbol 'f2fs_compress_free_page' was not
declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ma Feng <mafeng.ma@huawei.com>
---
fs/f2fs/compress.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index 4c7eaee..c7c5a8f 100644
--- a/fs/f2fs/compress.c
+++ b/fs/f2fs/compress.c
@@ -498,7 +498,7 @@ bool f2fs_is_compress_backend_ready(struct inode *inode)
}
static mempool_t *compress_page_pool = NULL;
-int num_compress_pages = 512;
+static int num_compress_pages = 512;
module_param(num_compress_pages, uint, 0444);
MODULE_PARM_DESC(num_compress_pages,
"Number of intermediate compress pages to preallocate");
@@ -527,7 +527,7 @@ static struct page *f2fs_compress_alloc_page(void)
return page;
}
-void f2fs_compress_free_page(struct page *page)
+static void f2fs_compress_free_page(struct page *page)
{
if (!page)
return;
--
2.6.2
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next reply other threads:[~2020-05-11 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 11:51 Ma Feng [this message]
2020-05-12 1:48 ` [f2fs-dev] [PATCH] f2fs: compress: make num_compress_pages and f2fs_compress_free_page static Chao Yu
2020-05-12 3:38 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1589197886-10580-1-git-send-email-mafeng.ma@huawei.com \
--to=mafeng.ma@huawei.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).