From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90942C433EF for ; Mon, 13 Sep 2021 09:33:47 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A33060D42; Mon, 13 Sep 2021 09:33:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2A33060D42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1mPiLR-0008Kw-8g; Mon, 13 Sep 2021 09:33:45 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1mPiLQ-0008Km-N2 for linux-f2fs-devel@lists.sourceforge.net; Mon, 13 Sep 2021 09:33:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-ID:In-Reply-To:Date:From:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TL0pMINnnnZXKmQBA+GHy9A2jFp+/fcqehmZA0s6WKE=; b=XnqQvr1ZHRwH6f3w5LM+0WXa8v Fz7mQdlkXy+/BcFFlT/MgxXCBUBLmCy2K0/nPZKahgRYzM08zmw4AzwYymfV2wERWUt3vS4JO9xVG ldTYIv4tb0/KtJ0NY6ZVqEdAiDNA/axam2oJ3RdFUvlZsOvKhjFvGlT3u6omkBHDzKhY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:From:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TL0pMINnnnZXKmQBA+GHy9A2jFp+/fcqehmZA0s6WKE=; b=W4AwTjP74FypOKfO3xOn+AB4Q0 kTH4igQ1xS8fIRrAVuaTQ/Vby1TFjLzlCzVmuL2PjYFKqL4d1OYbgqYnfNpyiZJOlDd5IlO2J58zD 63vlXCeQuQgsbhWdVX7XVXu7sr9iZZQP/tufwmUJ1w8GFko0d273Vifg0JVLJVsuRHlQ=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mPiLQ-0002yW-2u for linux-f2fs-devel@lists.sourceforge.net; Mon, 13 Sep 2021 09:33:44 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2599B60D42; Mon, 13 Sep 2021 09:33:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631525618; bh=piIeiAC9yhQFu+FX7/5huH/dyE8o919ZL0a7cJbonao=; h=Subject:To:Cc:From:Date:In-Reply-To:From; b=JMFSjBW8l6FRxkSK/iZc+XX4y7zR/0nlYdnXGlwpMiqEl2eX8CLX1yiztUbdEMwym HxmVaNHu0YpEWz0ECkwGvic9j5sHmhy3sXrTO9BKA1NHXh0gtRH53OaLwQx/r8ciVH 0MlDF9On2EeOCOsJEd1nNg9+AYLLL9G1IC2S9960= To: ebiggers@google.com, ebiggers@kernel.org, gregkh@linuxfoundation.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org From: Date: Mon, 13 Sep 2021 11:33:36 +0200 In-Reply-To: <20210908215033.1122580-3-ebiggers@kernel.org> Message-ID: <163152561619799@kroah.com> MIME-Version: 1.0 X-stable: commit X-Patchwork-Hint: ignore X-Headers-End: 1mPiLQ-0002yW-2u Subject: [f2fs-dev] Patch "ext4: report correct st_size for encrypted symlinks" has been added to the 4.19-stable tree X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable-commits@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net This is a note to let you know that I've just added the patch titled ext4: report correct st_size for encrypted symlinks to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: ext4-report-correct-st_size-for-encrypted-symlinks.patch and it can be found in the queue-4.19 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From foo@baz Mon Sep 13 11:31:12 AM CEST 2021 From: Eric Biggers Date: Wed, 8 Sep 2021 14:50:31 -0700 Subject: ext4: report correct st_size for encrypted symlinks To: stable@vger.kernel.org Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org Message-ID: <20210908215033.1122580-3-ebiggers@kernel.org> From: Eric Biggers commit 8c4bca10ceafc43b1ca0a9fab5fa27e13cbce99e upstream. The stat() family of syscalls report the wrong size for encrypted symlinks, which has caused breakage in several userspace programs. Fix this by calling fscrypt_symlink_getattr() after ext4_getattr() for encrypted symlinks. This function computes the correct size by reading and decrypting the symlink target (if it's not already cached). For more details, see the commit which added fscrypt_symlink_getattr(). Fixes: f348c252320b ("ext4 crypto: add symlink encryption") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20210702065350.209646-3-ebiggers@kernel.org Signed-off-by: Eric Biggers Signed-off-by: Greg Kroah-Hartman --- fs/ext4/symlink.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) --- a/fs/ext4/symlink.c +++ b/fs/ext4/symlink.c @@ -52,10 +52,19 @@ static const char *ext4_encrypted_get_li return paddr; } +static int ext4_encrypted_symlink_getattr(const struct path *path, + struct kstat *stat, u32 request_mask, + unsigned int query_flags) +{ + ext4_getattr(path, stat, request_mask, query_flags); + + return fscrypt_symlink_getattr(path, stat); +} + const struct inode_operations ext4_encrypted_symlink_inode_operations = { .get_link = ext4_encrypted_get_link, .setattr = ext4_setattr, - .getattr = ext4_getattr, + .getattr = ext4_encrypted_symlink_getattr, .listxattr = ext4_listxattr, }; Patches currently in stable-queue which might be from ebiggers@kernel.org are queue-4.19/ubifs-report-correct-st_size-for-encrypted-symlinks.patch queue-4.19/ext4-report-correct-st_size-for-encrypted-symlinks.patch queue-4.19/fscrypt-add-fscrypt_symlink_getattr-for-computing-st_size.patch queue-4.19/f2fs-report-correct-st_size-for-encrypted-symlinks.patch _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel