From: Bart Van Assche <bvanassche@acm.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2] loop: avoid EAGAIN, if offset or block_size are changed
Date: Tue, 19 Nov 2019 15:40:55 -0800 [thread overview]
Message-ID: <1e1aae74-bd6b-dddb-0c88-660aac33872c@acm.org> (raw)
In-Reply-To: <20190518005304.GA19446@jaegeuk-macbookpro.roam.corp.google.com>
On 5/17/19 5:53 PM, Jaegeuk Kim wrote:
> This patch tries to avoid EAGAIN due to nrpages!=0 that was originally trying
> to drop stale pages resulting in wrong data access.
>
> Report: https://bugs.chromium.org/p/chromium/issues/detail?id=938958#c38
Please provide a more detailed commit description. What is wrong with
the current implementation and why is the new behavior considered the
correct behavior?
This patch moves draining code from before the following comment to
after that comment:
/* I/O need to be drained during transfer transition */
Is that comment still correct or should it perhaps be updated?
Thanks,
Bart.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-11-19 23:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 0:47 [PATCH] loop: avoid EAGAIN, if offset or block_size are changed Jaegeuk Kim
2019-05-18 0:53 ` [PATCH v2] " Jaegeuk Kim
2019-06-17 21:08 ` [f2fs-dev] " Jaegeuk Kim
2019-11-18 18:36 ` [f2fs-dev] " Andrew Norrie
2019-11-19 4:00 ` Greg KH
2019-11-19 23:40 ` Bart Van Assche [this message]
2019-11-25 17:59 ` [f2fs-dev] [PATCH v2] " Jaegeuk Kim
2019-11-25 18:35 ` Bart Van Assche
2019-11-25 19:22 ` Jaegeuk Kim
2019-11-25 19:41 ` Bart Van Assche
2019-11-27 18:18 ` [f2fs-dev] [PATCH v3] " Jaegeuk Kim
2019-11-27 18:54 ` Bart Van Assche
2020-02-19 19:58 ` Andrew Norrie
2020-03-05 21:04 ` [f2fs-dev] [PATCH] " Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e1aae74-bd6b-dddb-0c88-660aac33872c@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).