From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3754C433FF for ; Tue, 6 Aug 2019 00:47:51 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C8912147A; Tue, 6 Aug 2019 00:47:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="iLaHGbt6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="Pq2ukLlo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="MitRhXXi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C8912147A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1hundn-0006fv-89; Tue, 06 Aug 2019 00:47:51 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hundl-0006fo-O5 for linux-f2fs-devel@lists.sourceforge.net; Tue, 06 Aug 2019 00:47:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Y6IIQupsmKPIt/+AtfUlcK5B97fQYAbWB426AfrMytY=; b=iLaHGbt62gqojd18UduCnD/k4N 2YnqM74B6sCztP4JMwpyN6edScMNW7+TA/ZH+tXNCv6hsf7Bv7T1H1IBuE6qrDkHZJVAjIADnmp4z h+hiph7062m8Kw7zNiRvEd3i78cfCc2/QySVZNPKhtaxbTgRn2E+WPlMgdKcx0X/EdQQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Y6IIQupsmKPIt/+AtfUlcK5B97fQYAbWB426AfrMytY=; b=Pq2ukLlor2nLHcXd/4ePgqw1WY VNEvJXcdMQyYdMHw4DPqAnBOKdRayfx+pRlvrdVqMC5CkgUDHA1B4s2xVPpcMexcXRGmS001Tq1tW EIiZWdFBp9QaJpOUxt3uVxCTIUpoYv+LoRik96hgQEzmqYQ3HEAwzoQZ45IcGygRrWcM=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1hundk-00CJLC-LE for linux-f2fs-devel@lists.sourceforge.net; Tue, 06 Aug 2019 00:47:49 +0000 Received: from localhost (unknown [104.132.0.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F05ED2147A; Tue, 6 Aug 2019 00:47:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565052463; bh=ZD4vORsgnPaIsOHKR8v3GrQbcKOsIaN9uQO0Isv1v4Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MitRhXXiQA/Zwk4ocmHFV+5HZS+nPwXbA3VgzGJla/98B0spBgUFJk0YRBP+EhpBy 9oJl0n/g8Wc/lf6fKC5Sxo9ufYgrHBiCsdNYVIlIondWGMWhZHJ9Z78l46bjQWlx87 zq2FiCRh3LQ9hBWvu0RpSUPq8dzxMacypW4X0gq8= Date: Mon, 5 Aug 2019 17:47:42 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: <20190806004742.GD98101@jaegeuk-macbookpro.roam.corp.google.com> References: <20181002020223.76087-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.2 (2017-04-18) X-Headers-End: 1hundk-00CJLC-LE Subject: Re: [f2fs-dev] [PATCH] fsck.f2fs: don't allocate new blocks on unclean shutdown X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 08/05, Chao Yu wrote: > Hi Jaegeuk, > > On 2018/10/2 10:02, Jaegeuk Kim wrote: > > + if (!is_set_ckpt_flags(cp, CP_UMOUNT_FLAG)) { > > + c.alloc_failed = 1; > > + return -EINVAL; > > + } > > When I test por_fsstress case w/ quota feature enabled, I suffer below error > during repair: > > Info: superblock features = f8 : extra_attr project_quota inode_checksum > flexible_inline_xattr quota_ino > Info: superblock encrypt level = 0, salt = 00000000000000000000000000000000 > Info: total FS sectors = 2097152 (8192 MB) > Info: CKPT version = 452b7568 > Info: checkpoint state = 846 : quota_need_fsck crc compacted_summary > orphan_inodes sudden-power-off > [fsck_chk_quota_files:1784] Fixing Quota file ([ 0] ino [0x4]) > [ERROR] quotaio_tree.c:83:write_blk:: Cannot write block (7188): Inappropriate > ioctl for device > [ERROR] quotaio_tree.c:110:get_free_dqblk:: Cannot allocate new quota block (out > of disk space). > > I found new_data_block() will reject block allocation on an unclean umounted > image, result in quota file repair failure. > > With current implementation, I think we should mount that image again for > recovery, then umount and run fsck on it again to repair quota file. Yes. > > However, user didn't be noticed that how to fix this... I know there is no such > report tho, I think we'd better fix this case in fsck, any thoughts? let > allocation skip fsynced datas? Actually, that was my TODO, but I had no time to fix it, but had to stop it to avoid further corruption. > > Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel