From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix wrong available node count calculation
Date: Fri, 9 Aug 2019 08:19:21 -0700 [thread overview]
Message-ID: <20190809151921.GB93481@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <7a47ec24-2352-7438-bed2-493a89d5c576@huawei.com>
On 08/06, Chao Yu wrote:
> On 2019/8/5 18:27, Chao Yu wrote:
> > In mkfs, we have counted quota file's node number in cp.valid_node_count,
> > so we have to avoid wrong substraction of quota node number in
> > .available_nid/.avail_node_count calculation.
> >
> > f2fs_write_check_point_pack()
> > {
> > ..
> > set_cp(valid_node_count, 1 + c.quota_inum + c.lpf_inum);
> >
> > Fixes: 292c196a3695 ("reserve nid resource for quota sysfile")
>
> Jaegeuk,
>
> Could you help to add prefix "f2fs: " into commit tile in your branch, I missed
> to add it. :P
Done. :)
>
> Thanks,
>
> > Fixes: 7b63f72f73af ("f2fs: fix to do sanity check on valid node/block count")
> > Signed-off-by: Chao Yu <yuchao0@huawei.com>
> > ---
> > fs/f2fs/node.c | 2 +-
> > fs/f2fs/super.c | 6 ++----
> > 2 files changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> > index a18b2a895771..d9ba1db2d01e 100644
> > --- a/fs/f2fs/node.c
> > +++ b/fs/f2fs/node.c
> > @@ -2964,7 +2964,7 @@ static int init_node_manager(struct f2fs_sb_info *sbi)
> >
> > /* not used nids: 0, node, meta, (and root counted as valid node) */
> > nm_i->available_nids = nm_i->max_nid - sbi->total_valid_node_count -
> > - sbi->nquota_files - F2FS_RESERVED_NODE_NUM;
> > + F2FS_RESERVED_NODE_NUM;
> > nm_i->nid_cnt[FREE_NID] = 0;
> > nm_i->nid_cnt[PREALLOC_NID] = 0;
> > nm_i->nat_cnt = 0;
> > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> > index 6a7f1166d068..118a31f90a37 100644
> > --- a/fs/f2fs/super.c
> > +++ b/fs/f2fs/super.c
> > @@ -1297,8 +1297,7 @@ static int f2fs_statfs(struct dentry *dentry, struct kstatfs *buf)
> > else
> > buf->f_bavail = 0;
> >
> > - avail_node_count = sbi->total_node_count - sbi->nquota_files -
> > - F2FS_RESERVED_NODE_NUM;
> > + avail_node_count = sbi->total_node_count - F2FS_RESERVED_NODE_NUM;
> >
> > if (avail_node_count > user_block_count) {
> > buf->f_files = user_block_count;
> > @@ -2750,8 +2749,7 @@ int f2fs_sanity_check_ckpt(struct f2fs_sb_info *sbi)
> > }
> >
> > valid_node_count = le32_to_cpu(ckpt->valid_node_count);
> > - avail_node_count = sbi->total_node_count - sbi->nquota_files -
> > - F2FS_RESERVED_NODE_NUM;
> > + avail_node_count = sbi->total_node_count - F2FS_RESERVED_NODE_NUM;
> > if (valid_node_count > avail_node_count) {
> > f2fs_err(sbi, "Wrong valid_node_count: %u, avail_node_count: %u",
> > valid_node_count, avail_node_count);
> >
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2019-08-09 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 10:27 [f2fs-dev] [PATCH v2] f2fs: fix wrong available node count calculation Chao Yu
2019-08-06 3:24 ` Chao Yu
2019-08-09 15:19 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809151921.GB93481@jaegeuk-macbookpro.roam.corp.google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).