From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 1/4] fsck.f2fs: fix to recover out-of-border inline size
Date: Thu, 15 Aug 2019 18:03:03 -0700 [thread overview]
Message-ID: <20190816010303.GA66488@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <20190815223934.GB61672@jaegeuk-macbookpro.roam.corp.google.com>
On 08/15, Jaegeuk Kim wrote:
> On 08/12, Chao Yu wrote:
> > It tries to let fsck be noticed wrong inline size, and do the fix.
> >
> > Signed-off-by: Chao Yu <yuchao0@huawei.com>
> > ---
> > fsck/fsck.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/fsck/fsck.c b/fsck/fsck.c
> > index d53317c..7eb599d 100644
> > --- a/fsck/fsck.c
> > +++ b/fsck/fsck.c
> > @@ -771,6 +771,8 @@ void fsck_chk_inode_blk(struct f2fs_sb_info *sbi, u32 nid,
> > ofs = get_extra_isize(node_blk);
> >
> > if ((node_blk->i.i_inline & F2FS_INLINE_DATA)) {
> > + unsigned int inline_size = MAX_INLINE_DATA(node_blk);
> > +
> > if (le32_to_cpu(node_blk->i.i_addr[ofs]) != 0) {
> > /* should fix this bug all the time */
> > FIX_MSG("inline_data has wrong 0'th block = %x",
> > @@ -779,6 +781,12 @@ void fsck_chk_inode_blk(struct f2fs_sb_info *sbi, u32 nid,
> > node_blk->i.i_blocks = cpu_to_le64(*blk_cnt);
> > need_fix = 1;
> > }
> > + if (!i_size || i_size > inline_size) {
>
> i_size=0 should be fine?
Missed v2.
>
> > + node_blk->i.i_size = cpu_to_le64(inline_size);
> > + FIX_MSG("inline_data has wrong i_size %lu",
> > + (unsigned long)i_size);
> > + need_fix = 1;
> > + }
> > if (!(node_blk->i.i_inline & F2FS_DATA_EXIST)) {
> > char buf[MAX_INLINE_DATA(node_blk)];
> > memset(buf, 0, MAX_INLINE_DATA(node_blk));
> > --
> > 2.18.0.rc1
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2019-08-16 1:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 11:45 [f2fs-dev] [PATCH 1/4] fsck.f2fs: fix to recover out-of-border inline size Chao Yu
2019-08-12 11:45 ` [f2fs-dev] [PATCH 2/4] fsck.f2fs: fix to check c.fix_on before repair Chao Yu
2019-08-16 1:06 ` Jaegeuk Kim
2019-08-16 1:20 ` Chao Yu
2019-08-20 11:34 ` Chao Yu
2019-08-12 11:45 ` [f2fs-dev] [PATCH 3/4] fsck.f2fs: fix to show removed x_nid correctly Chao Yu
2019-08-12 11:45 ` [f2fs-dev] [PATCH 4/4] fsck.f2fs: fix symlink correctly Chao Yu
2019-08-15 22:39 ` [f2fs-dev] [PATCH 1/4] fsck.f2fs: fix to recover out-of-border inline size Jaegeuk Kim
2019-08-16 1:03 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816010303.GA66488@jaegeuk-macbookpro.roam.corp.google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).