From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FEA7C3A5A2 for ; Fri, 23 Aug 2019 22:40:58 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DE2521019; Fri, 23 Aug 2019 22:40:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="au0ekMxH"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="f1tWM66a"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fPbXivgP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DE2521019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1i1IEr-0003y0-Cz; Fri, 23 Aug 2019 22:40:57 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1i1IEq-0003xo-Kz for linux-f2fs-devel@lists.sourceforge.net; Fri, 23 Aug 2019 22:40:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CvrATbvJZ5YXZnU+IwQ0yrOpoNEooZFLKR0d2HZ8QWs=; b=au0ekMxHW/qpkq17A5GYLcbVjY KzyXVxldR6lTT1RSbGMFxX195n3WeKxwgHppfhapTQUJhe2FJQwwy88WFz0EWmLKrrt2EY5puhoFx psPKY9CKbd//PpRPuFhSuRoftobEQWIhUt0OIiL4f4h0oYWNX7w0vfEI8aAYDXjs1jOA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=CvrATbvJZ5YXZnU+IwQ0yrOpoNEooZFLKR0d2HZ8QWs=; b=f 1tWM66aiqPUI/pFH6go4KZsY6qSNPSgD6UZXya9U0UdrdNszgWaU2fbWPVN0zY0oNo6Qg/AhS11E2 yI+aDViThoMGsMhmRnkW32aVWmZfRVwZZFwHxSpxMUGJzenVDJ2LTJ6FpoLvJJkNNgd4eugSrcca4 TbkssNeU6I/3K/b8=; Received: from mail-pg1-f193.google.com ([209.85.215.193]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) id 1i1IEo-00Dw9d-25 for linux-f2fs-devel@lists.sourceforge.net; Fri, 23 Aug 2019 22:40:56 +0000 Received: by mail-pg1-f193.google.com with SMTP id l21so6536962pgm.3 for ; Fri, 23 Aug 2019 15:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CvrATbvJZ5YXZnU+IwQ0yrOpoNEooZFLKR0d2HZ8QWs=; b=fPbXivgPdGtIovycNkVCxHbrZ7NUSTQsLAuVEFrc0XBJP2xit8IhpYFnbUAfR4zJe3 Qsf85y2NVLPMW/YNoktKFjwIWzq5Pc0ltcJYp5+wT27HdI2zCoQX4yM7xSWI3xMwY/QV LMwSBOIW0ozHljET7S2bsB2P+ihZjZyMayGF5D7GWzQY5o1Rb8o7ttaU040nKiS0V4s6 zNzRQ+IXzikxGDIXOA7xY5PMyUNfzhtc1YI2Rtt4e2xdi0Y11kGwTzSyDdn1rZyyLlZ3 sb0qxH4DjvimzrG87GOx+oXre+TMayQbufpj4fkQmgwSrUFTjsiHzyQzZSKIHAruTi1b bLtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CvrATbvJZ5YXZnU+IwQ0yrOpoNEooZFLKR0d2HZ8QWs=; b=BK/ScjALVSHxJBT9P6ubZ1UNadUUInSax2q+VNHwMDi+OHa/8isT5+KC04q/qe7kIS 715D4fB8rR/zSXh5V2CLSq7pd6PZpCWH0BAAcPQnLODUMxnZdHwZpqliIk7m66fKk2hl JmHg4nm5KUZVm+e3U8sWIU4R1td+zXoR6wg+5DPWLO36XWgYFomck4WqGcExsivkwifr CBbjQ2WrS0Rzmi1oAOITUI10g5nlu4TBZrsE2IojO9AWyTuxzC+P5k/ku+U/sFtoME4J 6TYSsv952yAOVVFQZJhVjbETPa9qoFyfwjqq+QDn1CD5xRroxWIzAWsB4HbPs9pVf8S9 /esg== X-Gm-Message-State: APjAAAUceTS2k40shqL0lSq0yej/Mm+vlOpF8D4CIzZW0UnWx/RJ5cZd 1QJC73BOeMLt4AjX+5YH8y0KK6kd X-Google-Smtp-Source: APXvYqw2IV3GP+YQhrTZ49RDgXMsZqnxH4Ibmpk3flcmDtglDZbyOVbJXbHpsNRU0h5zxqsP6FnlCQ== X-Received: by 2002:a17:90a:1d0:: with SMTP id 16mr7425139pjd.98.1566600048045; Fri, 23 Aug 2019 15:40:48 -0700 (PDT) Received: from curare.nss.cs.ubc.ca (coconut.cs.ubc.ca. [198.162.52.139]) by smtp.gmail.com with ESMTPSA id a18sm2699070pgl.44.2019.08.23.15.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Aug 2019 15:40:47 -0700 (PDT) From: Surbhi Palande X-Google-Original-From: Surbhi Palande To: linux-f2fs-devel@lists.sourceforge.net Date: Fri, 23 Aug 2019 15:40:45 -0700 Message-Id: <20190823224045.26377-1-csurbhi@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Headers-End: 1i1IEo-00Dw9d-25 Subject: [f2fs-dev] [PATCH] Check all the data segments against all node ones. X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Surbhi Palande , Jaegeuk Kim Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net As a part of the sanity checking while mounting, distinct segment number assignment to data and node segments is verified. Fixing a small bug in this verification between node and data segments. We need to check all the data segments with all the node segments. Signed-off-by: Surbhi Palande --- fs/f2fs/super.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 6b959bb..1ec4d95 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -2684,11 +2684,11 @@ int f2fs_sanity_check_ckpt(struct f2fs_sb_info *sbi) } } for (i = 0; i < NR_CURSEG_NODE_TYPE; i++) { - for (j = i; j < NR_CURSEG_DATA_TYPE; j++) { + for (j = 0; j < NR_CURSEG_DATA_TYPE; j++) { if (le32_to_cpu(ckpt->cur_node_segno[i]) == le32_to_cpu(ckpt->cur_data_segno[j])) { f2fs_msg(sbi->sb, KERN_ERR, - "Data segment (%u) and Data segment (%u)" + "Node segment (%u) and Data segment (%u)" " has the same segno: %u", i, j, le32_to_cpu(ckpt->cur_node_segno[i])); return 1; -- 2.7.4 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel