From: Jaegeuk Kim <jaegeuk@kernel.org>
To: "zhengbin (A)" <zhengbin13@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: Make f2fs_fname_setup_ci_filename static
Date: Sun, 1 Sep 2019 00:27:13 -0700 [thread overview]
Message-ID: <20190901072713.GC49907@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <bf99e560-ec3d-2360-3286-661172ee2eff@huawei.com>
On 08/31, zhengbin (A) wrote:
> On 2019/8/31 10:30, Chao Yu wrote:
>
> > Hi Zheng,
> >
> > Thanks for the patch, the original patch is still in dev branch, I suggest we
> > can merge it into original patch, do you mind that?
> Agree with it
Thanks, I've applied.
> >
> > Thanks,
> >
> > On 2019/8/31 9:46, zhengbin wrote:
> >> Fix sparse warning:
> >>
> >> fs/f2fs/dir.c:142:6: warning: symbol 'f2fs_fname_setup_ci_filename' was not declared. Should it be static?
> >>
> >> Reported-by: Hulk Robot <hulkci@huawei.com>
> >> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> >> ---
> >> fs/f2fs/dir.c | 6 +++---
> >> 1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
> >> index 9de688a..147fa5a 100644
> >> --- a/fs/f2fs/dir.c
> >> +++ b/fs/f2fs/dir.c
> >> @@ -139,9 +139,9 @@ int f2fs_ci_compare(const struct inode *parent, const struct qstr *name,
> >> return ret;
> >> }
> >>
> >> -void f2fs_fname_setup_ci_filename(struct inode *dir,
> >> - const struct qstr *iname,
> >> - struct fscrypt_str *cf_name)
> >> +static void f2fs_fname_setup_ci_filename(struct inode *dir,
> >> + const struct qstr *iname,
> >> + struct fscrypt_str *cf_name)
> >> {
> >> struct f2fs_sb_info *sbi = F2FS_I_SB(dir);
> >>
> >> --
> >> 2.7.4
> >>
> >>
> >>
> >> _______________________________________________
> >> Linux-f2fs-devel mailing list
> >> Linux-f2fs-devel@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> >> .
> >>
> > .
> >
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2019-09-01 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 1:46 [f2fs-dev] [PATCH] f2fs: Make f2fs_fname_setup_ci_filename static zhengbin
2019-08-31 2:30 ` Chao Yu
2019-08-31 2:33 ` zhengbin (A)
2019-09-01 7:27 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190901072713.GC49907@jaegeuk-macbookpro.roam.corp.google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).