Linux-f2fs-devel Archive on lore.kernel.org
 help / color / Atom feed
* [f2fs-dev] [PATCH] f2fs: Make f2fs_fname_setup_ci_filename static
@ 2019-08-31  1:46 zhengbin
  2019-08-31  2:30 ` Chao Yu
  0 siblings, 1 reply; 4+ messages in thread
From: zhengbin @ 2019-08-31  1:46 UTC (permalink / raw)
  To: jaegeuk, chao, linux-f2fs-devel; +Cc: zhengbin13

Fix sparse warning:

fs/f2fs/dir.c:142:6: warning: symbol 'f2fs_fname_setup_ci_filename' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 fs/f2fs/dir.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
index 9de688a..147fa5a 100644
--- a/fs/f2fs/dir.c
+++ b/fs/f2fs/dir.c
@@ -139,9 +139,9 @@ int f2fs_ci_compare(const struct inode *parent, const struct qstr *name,
 	return ret;
 }

-void f2fs_fname_setup_ci_filename(struct inode *dir,
-					const struct qstr *iname,
-					struct fscrypt_str *cf_name)
+static void f2fs_fname_setup_ci_filename(struct inode *dir,
+					       const struct qstr *iname,
+					       struct fscrypt_str *cf_name)
 {
 	struct f2fs_sb_info *sbi = F2FS_I_SB(dir);

--
2.7.4



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [f2fs-dev] [PATCH] f2fs: Make f2fs_fname_setup_ci_filename static
  2019-08-31  1:46 [f2fs-dev] [PATCH] f2fs: Make f2fs_fname_setup_ci_filename static zhengbin
@ 2019-08-31  2:30 ` Chao Yu
  2019-08-31  2:33   ` zhengbin (A)
  0 siblings, 1 reply; 4+ messages in thread
From: Chao Yu @ 2019-08-31  2:30 UTC (permalink / raw)
  To: zhengbin, jaegeuk, chao, linux-f2fs-devel

Hi Zheng,

Thanks for the patch, the original patch is still in dev branch, I suggest we
can merge it into original patch, do you mind that?

Thanks,

On 2019/8/31 9:46, zhengbin wrote:
> Fix sparse warning:
> 
> fs/f2fs/dir.c:142:6: warning: symbol 'f2fs_fname_setup_ci_filename' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
>  fs/f2fs/dir.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
> index 9de688a..147fa5a 100644
> --- a/fs/f2fs/dir.c
> +++ b/fs/f2fs/dir.c
> @@ -139,9 +139,9 @@ int f2fs_ci_compare(const struct inode *parent, const struct qstr *name,
>  	return ret;
>  }
> 
> -void f2fs_fname_setup_ci_filename(struct inode *dir,
> -					const struct qstr *iname,
> -					struct fscrypt_str *cf_name)
> +static void f2fs_fname_setup_ci_filename(struct inode *dir,
> +					       const struct qstr *iname,
> +					       struct fscrypt_str *cf_name)
>  {
>  	struct f2fs_sb_info *sbi = F2FS_I_SB(dir);
> 
> --
> 2.7.4
> 
> 
> 
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> .
> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [f2fs-dev] [PATCH] f2fs: Make f2fs_fname_setup_ci_filename static
  2019-08-31  2:30 ` Chao Yu
@ 2019-08-31  2:33   ` zhengbin (A)
  2019-09-01  7:27     ` Jaegeuk Kim
  0 siblings, 1 reply; 4+ messages in thread
From: zhengbin (A) @ 2019-08-31  2:33 UTC (permalink / raw)
  To: Chao Yu, jaegeuk, chao, linux-f2fs-devel

On 2019/8/31 10:30, Chao Yu wrote:

> Hi Zheng,
>
> Thanks for the patch, the original patch is still in dev branch, I suggest we
> can merge it into original patch, do you mind that?
Agree with it
>
> Thanks,
>
> On 2019/8/31 9:46, zhengbin wrote:
>> Fix sparse warning:
>>
>> fs/f2fs/dir.c:142:6: warning: symbol 'f2fs_fname_setup_ci_filename' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: zhengbin <zhengbin13@huawei.com>
>> ---
>>  fs/f2fs/dir.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
>> index 9de688a..147fa5a 100644
>> --- a/fs/f2fs/dir.c
>> +++ b/fs/f2fs/dir.c
>> @@ -139,9 +139,9 @@ int f2fs_ci_compare(const struct inode *parent, const struct qstr *name,
>>  	return ret;
>>  }
>>
>> -void f2fs_fname_setup_ci_filename(struct inode *dir,
>> -					const struct qstr *iname,
>> -					struct fscrypt_str *cf_name)
>> +static void f2fs_fname_setup_ci_filename(struct inode *dir,
>> +					       const struct qstr *iname,
>> +					       struct fscrypt_str *cf_name)
>>  {
>>  	struct f2fs_sb_info *sbi = F2FS_I_SB(dir);
>>
>> --
>> 2.7.4
>>
>>
>>
>> _______________________________________________
>> Linux-f2fs-devel mailing list
>> Linux-f2fs-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
>> .
>>
> .
>



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [f2fs-dev] [PATCH] f2fs: Make f2fs_fname_setup_ci_filename static
  2019-08-31  2:33   ` zhengbin (A)
@ 2019-09-01  7:27     ` Jaegeuk Kim
  0 siblings, 0 replies; 4+ messages in thread
From: Jaegeuk Kim @ 2019-09-01  7:27 UTC (permalink / raw)
  To: zhengbin (A); +Cc: linux-f2fs-devel

On 08/31, zhengbin (A) wrote:
> On 2019/8/31 10:30, Chao Yu wrote:
> 
> > Hi Zheng,
> >
> > Thanks for the patch, the original patch is still in dev branch, I suggest we
> > can merge it into original patch, do you mind that?
> Agree with it

Thanks, I've applied.

> >
> > Thanks,
> >
> > On 2019/8/31 9:46, zhengbin wrote:
> >> Fix sparse warning:
> >>
> >> fs/f2fs/dir.c:142:6: warning: symbol 'f2fs_fname_setup_ci_filename' was not declared. Should it be static?
> >>
> >> Reported-by: Hulk Robot <hulkci@huawei.com>
> >> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> >> ---
> >>  fs/f2fs/dir.c | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
> >> index 9de688a..147fa5a 100644
> >> --- a/fs/f2fs/dir.c
> >> +++ b/fs/f2fs/dir.c
> >> @@ -139,9 +139,9 @@ int f2fs_ci_compare(const struct inode *parent, const struct qstr *name,
> >>  	return ret;
> >>  }
> >>
> >> -void f2fs_fname_setup_ci_filename(struct inode *dir,
> >> -					const struct qstr *iname,
> >> -					struct fscrypt_str *cf_name)
> >> +static void f2fs_fname_setup_ci_filename(struct inode *dir,
> >> +					       const struct qstr *iname,
> >> +					       struct fscrypt_str *cf_name)
> >>  {
> >>  	struct f2fs_sb_info *sbi = F2FS_I_SB(dir);
> >>
> >> --
> >> 2.7.4
> >>
> >>
> >>
> >> _______________________________________________
> >> Linux-f2fs-devel mailing list
> >> Linux-f2fs-devel@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> >> .
> >>
> > .
> >


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-31  1:46 [f2fs-dev] [PATCH] f2fs: Make f2fs_fname_setup_ci_filename static zhengbin
2019-08-31  2:30 ` Chao Yu
2019-08-31  2:33   ` zhengbin (A)
2019-09-01  7:27     ` Jaegeuk Kim

Linux-f2fs-devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-f2fs-devel/0 linux-f2fs-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-f2fs-devel linux-f2fs-devel/ https://lore.kernel.org/linux-f2fs-devel \
		linux-f2fs-devel@lists.sourceforge.net linux-f2fs-devel@archiver.kernel.org
	public-inbox-index linux-f2fs-devel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/net.sourceforge.lists.linux-f2fs-devel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox