Re: [f2fs-dev] [PATCH] Check all the data segments against all node ones.

From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Surbhi Palande <f2fsnewbie@gmail.com>
Cc: Surbhi Palande <csurbhi@gmail.com>,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] Check all the data segments against all node ones.
Date: Mon, 2 Sep 2019 15:45:11 -0700	[thread overview]
Message-ID: <20190902224511.GB71929@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <20190823224045.26377-1-csurbhi@gmail.com>

Hi Surbhi,

Applied as "f2fs: check all the data segments against all node ones".

Thanks,

On 08/23, Surbhi Palande wrote:
> As a part of the sanity checking while mounting, distinct segment number
> assignment to data and node segments is verified. Fixing a small bug in
> this verification between node and data segments. We need to check all
> the data segments with all the node segments.
> 
> Signed-off-by: Surbhi Palande <csurbhi@gmail.com>
> ---
>  fs/f2fs/super.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 6b959bb..1ec4d95 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -2684,11 +2684,11 @@ int f2fs_sanity_check_ckpt(struct f2fs_sb_info *sbi)
>  		}
>  	}
>  	for (i = 0; i < NR_CURSEG_NODE_TYPE; i++) {
> -		for (j = i; j < NR_CURSEG_DATA_TYPE; j++) {
> +		for (j = 0; j < NR_CURSEG_DATA_TYPE; j++) {
>  			if (le32_to_cpu(ckpt->cur_node_segno[i]) ==
>  				le32_to_cpu(ckpt->cur_data_segno[j])) {
>  				f2fs_msg(sbi->sb, KERN_ERR,
> -					"Data segment (%u) and Data segment (%u)"
> +					"Node segment (%u) and Data segment (%u)"
>  					" has the same segno: %u", i, j,
>  					le32_to_cpu(ckpt->cur_node_segno[i]));
>  				return 1;
> -- 
> 2.7.4

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel