From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Theodore Ts'o <tytso@mit.edu>,
linux-api@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
David Howells <dhowells@redhat.com>,
linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org, Victor Hsieh <victorhsieh@google.com>
Subject: Re: [f2fs-dev] [PATCH 1/4] statx: define STATX_ATTR_VERITY
Date: Wed, 6 Nov 2019 17:44:20 -0800 [thread overview]
Message-ID: <20191107014420.GD15212@magnolia> (raw)
In-Reply-To: <20191029204141.145309-2-ebiggers@kernel.org>
On Tue, Oct 29, 2019 at 01:41:38PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Add a statx attribute bit STATX_ATTR_VERITY which will be set if the
> file has fs-verity enabled. This is the statx() equivalent of
> FS_VERITY_FL which is returned by FS_IOC_GETFLAGS.
>
> This is useful because it allows applications to check whether a file is
> a verity file without opening it. Opening a verity file can be
> expensive because the fsverity_info is set up on open, which involves
> parsing metadata and optionally verifying a cryptographic signature.
>
> This is analogous to how various other bits are exposed through both
> FS_IOC_GETFLAGS and statx(), e.g. the encrypt bit.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> include/linux/stat.h | 3 ++-
> include/uapi/linux/stat.h | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/stat.h b/include/linux/stat.h
> index 765573dc17d659..528c4baad09146 100644
> --- a/include/linux/stat.h
> +++ b/include/linux/stat.h
> @@ -33,7 +33,8 @@ struct kstat {
> STATX_ATTR_IMMUTABLE | \
> STATX_ATTR_APPEND | \
> STATX_ATTR_NODUMP | \
> - STATX_ATTR_ENCRYPTED \
> + STATX_ATTR_ENCRYPTED | \
> + STATX_ATTR_VERITY \
> )/* Attrs corresponding to FS_*_FL flags */
> u64 ino;
> dev_t dev;
> diff --git a/include/uapi/linux/stat.h b/include/uapi/linux/stat.h
> index 7b35e98d3c58b1..ad80a5c885d598 100644
> --- a/include/uapi/linux/stat.h
> +++ b/include/uapi/linux/stat.h
> @@ -167,8 +167,8 @@ struct statx {
> #define STATX_ATTR_APPEND 0x00000020 /* [I] File is append-only */
> #define STATX_ATTR_NODUMP 0x00000040 /* [I] File is not to be dumped */
> #define STATX_ATTR_ENCRYPTED 0x00000800 /* [I] File requires key to decrypt in fs */
> -
> #define STATX_ATTR_AUTOMOUNT 0x00001000 /* Dir: Automount trigger */
> +#define STATX_ATTR_VERITY 0x00100000 /* [I] Verity protected file */
Any reason why this wasn't 0x2000?
If there's a manpage update that goes with this, then...
Acked-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
>
>
> #endif /* _UAPI_LINUX_STAT_H */
> --
> 2.24.0.rc1.363.gb1bccd3e3d-goog
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-11-07 1:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 20:41 [f2fs-dev] [PATCH 0/4] statx: expose the fs-verity bit Eric Biggers
2019-10-29 20:41 ` [f2fs-dev] [PATCH 1/4] statx: define STATX_ATTR_VERITY Eric Biggers
2019-11-07 1:44 ` Darrick J. Wong [this message]
2019-11-07 22:02 ` [f2fs-dev] [man-pages RFC PATCH] statx.2: document STATX_ATTR_VERITY Eric Biggers
2019-11-08 0:47 ` Darrick J. Wong
[not found] ` <5DC525E8.4060705@bfs.de>
2019-11-08 19:35 ` Eric Biggers
[not found] ` <5DC714DB.9060007@bfs.de>
2019-11-13 20:31 ` Eric Biggers
2019-11-07 22:12 ` [f2fs-dev] [PATCH 1/4] statx: define STATX_ATTR_VERITY Eric Biggers
2019-10-29 20:41 ` [f2fs-dev] [PATCH 2/4] ext4: support STATX_ATTR_VERITY Eric Biggers
2019-10-29 20:41 ` [f2fs-dev] [PATCH 3/4] f2fs: " Eric Biggers
2019-10-29 20:41 ` [f2fs-dev] [PATCH 4/4] docs: fs-verity: mention statx() support Eric Biggers
2019-11-06 21:57 ` [f2fs-dev] [PATCH 0/4] statx: expose the fs-verity bit Eric Biggers
2019-11-13 20:20 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107014420.GD15212@magnolia \
--to=darrick.wong@oracle.com \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=victorhsieh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).