From: Christoph Hellwig <hch@infradead.org>
To: ira.weiny@intel.com
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
Jan Kara <jack@suse.cz>, Dave Chinner <david@fromorbit.com>,
Josef Bacik <josef@toxicpanda.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-xfs@vger.kernel.org, Chris Mason <clm@fb.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
David Sterba <dsterba@suse.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-f2fs-devel@lists.sourceforge.net,
Trond Myklebust <trond.myklebust@hammerspace.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 2/2] fs: Move swap_[de]activate to file_operations
Date: Mon, 11 Nov 2019 22:55:07 -0800 [thread overview]
Message-ID: <20191112065507.GA15915@infradead.org> (raw)
In-Reply-To: <20191112003452.4756-3-ira.weiny@intel.com>
On Mon, Nov 11, 2019 at 04:34:52PM -0800, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
>
> swap_activate() and swap_deactivate() have nothing to do with
> address spaces. We want to eventually make the address space operations
> dynamic to switch inode flags on the fly. So to simplify this code as
> well as properly track these operations we move these functions to the
> file_operations vector.
What is the point? If we switch aops for DAX vs not we might as well
switch file operations as well, as they pretty much are entirely
different.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-11-12 6:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 0:34 [f2fs-dev] [PATCH 0/2] Move swap functions out of address space operations ira.weiny
2019-11-12 0:34 ` [f2fs-dev] [PATCH 1/2] fs: Clean up mapping variable ira.weiny
2019-11-12 1:20 ` Darrick J. Wong
2019-11-12 0:34 ` [f2fs-dev] [PATCH 2/2] fs: Move swap_[de]activate to file_operations ira.weiny
2019-11-12 0:43 ` Andrew Morton
2019-11-12 12:00 ` Nikolay Borisov
2019-11-12 13:33 ` Jan Kara
2019-11-12 17:05 ` Weiny, Ira
2019-11-12 1:20 ` Darrick J. Wong
2019-11-12 23:52 ` Ira Weiny
2019-11-12 6:55 ` Christoph Hellwig [this message]
2019-11-12 13:30 ` Jan Kara
2019-11-12 17:09 ` Weiny, Ira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112065507.GA15915@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=anna.schumaker@netapp.com \
--cc=clm@fb.com \
--cc=david@fromorbit.com \
--cc=dsterba@suse.com \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).