From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84567C43215 for ; Fri, 15 Nov 2019 19:22:47 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 542A0206D9; Fri, 15 Nov 2019 19:22:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="k1YOCfcK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="P89Cz4ZS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bjZdfDwh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 542A0206D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1iVhB8-0001xy-Bt; Fri, 15 Nov 2019 19:22:46 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iVhB7-0001xm-DA for linux-f2fs-devel@lists.sourceforge.net; Fri, 15 Nov 2019 19:22:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yJITfy6BztaOxNcsFF2p7gB6cPp8/NfLQQZNOBNCXW8=; b=k1YOCfcK+BI4qfwzlI17fPSVAu cXJgT+ajL3A9sPpuk8GHe0As44HcE6ZHvJTv/YRxg6X/ys6A69Y/iR8MjxWakTc1xTlgR9HX6wBEF wwkkqsT4R4Sk6x7nvdSl/KyJD2RS7uu7GdIVj9DgoplWy20uq63wnBie6SxCSw9m9h3Y=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yJITfy6BztaOxNcsFF2p7gB6cPp8/NfLQQZNOBNCXW8=; b=P89Cz4ZSWiGDwRmxw1x3RI9Lmy 5S01uC/7MNfKWZrL7QKF2E7DF63Cm6vVo/kK5Q+fgo14VBR8v7CLrTfLQs7pQ/YZiQPd2/o8NcXag TLdtBelqzpddgKha3TMPngzkePzLLfsxSU7CKUPZMgjS/+coT22Ku6qtoRt7s2G6Uvy0=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1iVhAy-001EgV-3k for linux-f2fs-devel@lists.sourceforge.net; Fri, 15 Nov 2019 19:22:44 +0000 Received: from sol.localdomain (c-24-5-143-220.hsd1.ca.comcast.net [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 36094206D9; Fri, 15 Nov 2019 19:22:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573845749; bh=upuiRVOg48zBrOcDo8mSF+x02Zd4aynU2rKOYkmP0Ug=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bjZdfDwhBnWRxGaakLSBtRR3lNyx9RSw1w8Q+az70jtKCUxDBYcteMj6kM7uw1+BJ mT5QmqPPX5h41lBPcVfK/APGOyYDw5helVm2UUL7TRYd0VcOKDXrzEOKHmiyfg5EGU WfIiJ5bxXeb0nzFxv6xnpeSLrmHLYQl8Nq/0zAJ4= Date: Fri, 15 Nov 2019 11:22:27 -0800 From: Eric Biggers To: Jarkko Sakkinen Message-ID: <20191115192227.GA150987@sol.localdomain> References: <20191107001259.115018-1-ebiggers@kernel.org> <20191115172832.GA21300@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191115172832.GA21300@linux.intel.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Headers-End: 1iVhAy-001EgV-3k Subject: Re: [f2fs-dev] [PATCH] fscrypt: support passing a keyring key to FS_IOC_ADD_ENCRYPTION_KEY X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Howells , "Theodore Y . Ts'o" , Ondrej Mosnacek , linux-f2fs-devel@lists.sourceforge.net, Paul Lawrence , linux-fscrypt@vger.kernel.org, keyrings@vger.kernel.org, linux-mtd@lists.infradead.org, Ondrej Kozina , Jaegeuk Kim , linux-ext4@vger.kernel.org, Paul Crowley Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Fri, Nov 15, 2019 at 07:28:53PM +0200, Jarkko Sakkinen wrote: > > I don't see anything obviously wrong. Just would reformat it a bit. > How you tested it? > I'm not sure all the blank lines you're suggesting would be an improvement. The ones in fscrypt_provisioning_key_preparse() might make sense though. I'm working on an xfstest for this: https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id=24ab6abb7cf6a80be44b7c72b73f0519ccaa5a97 It's not quite ready, though. I'll post it for review when it is. Someone is also planning to update Android userspace to use this. So if there are any issues from that, I'll hear about it. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel